Skip to content

Use include instead of build in matrix #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhucka merged 2 commits into from
Oct 21, 2025
Merged

Use include instead of build in matrix #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a53a06
Use `include` instead of `build` in matrix
mhucka Oct 20, 2025
d6325ab
Merge branch 'main' into mh-tweak-ci-matrix
mhucka Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ concurrency:

jobs:
build_dist:
runs-on: ${{matrix.build.os}}
runs-on: ${{matrix.os}}
strategy:
fail-fast: false
matrix:
build: [
include: [
{os: ubuntu-latest, dist: cp310-manylinux_x86_64, arch: x86_64},
{os: ubuntu-latest, dist: cp311-manylinux_x86_64, arch: x86_64},
{os: ubuntu-latest, dist: cp312-manylinux_x86_64, arch: x86_64},
Expand Down Expand Up @@ -89,9 +89,9 @@ jobs:
{os: windows-latest, dist: cp314-win_amd64, arch: AMD64},
]
env:
MACOSX_DEPLOYMENT_TARGET: ${{matrix.build.target}}
CIBW_BUILD: ${{matrix.build.dist}}
CIBW_ARCHS: ${{matrix.build.arch}}
MACOSX_DEPLOYMENT_TARGET: ${{matrix.target}}
CIBW_BUILD: ${{matrix.dist}}
CIBW_ARCHS: ${{matrix.arch}}
CIBW_TEST_REQUIRES: pytest pytest-xdist stim~=1.15 sinter pygltflib
CIBW_TEST_COMMAND: pytest -n auto {project}/src
CIBW_PRERELEASE_PYTHONS: 1
Expand All @@ -106,9 +106,9 @@ jobs:
- run: python tools/overwrite_dev_versions_with_date.py
- run: python -m pip install pybind11~=2.11.1 cibuildwheel~=3.2.0 setuptools
- run: python -m cibuildwheel --print-build-identifiers
- if: matrix.build.arch != 'AMD64'
- if: matrix.arch != 'AMD64'
run: python -m cibuildwheel --output-dir dist
- if: matrix.build.arch == 'AMD64'
- if: matrix.arch == 'AMD64'
env:
# These paths are on GitHub runners.
CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: 'delvewheel repair -v --add-path "D:\\a\\chromobius\\chromobius\\dist;D:\\a\\chromobius\\chromobius" -w {dest_dir} {wheel}'
Expand All @@ -119,7 +119,7 @@ jobs:
python -m cibuildwheel --output-dir dist
- uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
with:
name: "dist-chromobius-${{matrix.build.os}}-${{matrix.build.dist}}-${{matrix.build.arch}}"
name: "dist-chromobius-${{matrix.os}}-${{matrix.dist}}-${{matrix.arch}}"
path: dist/*
build_sdist:
runs-on: ubuntu-latest
Expand Down