Fix bugs found during code audit#191
Open
phillip-kruger wants to merge 1 commit intoquarkiverse:mainfrom
Open
Conversation
- Fix inverted condition in searchDocs() — extension filter was never sent to server - Add null guard in ChappieHotReplacementSetup.close() to prevent NPE on shutdown - Fix CPU spin in log streaming: remove inner while-loop, assign logTask for cancellation - Replace ex.printStackTrace() with LOG.error() in 3 config methods - Use shared static HttpClient instead of creating new one per request - Add .exceptionally() handler to fire-and-forget deleteChat() call - Synchronize config file reads/writes with configLock to prevent corruption - Include response body in HTTP error exception messages for debugging - Log actual image name and error in DevService fallback warning Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic bug, NPE, CPU spin, concurrency