[Fix #261] Adding JPA persistence plugin#279
Open
fjtirado wants to merge 2 commits intoquarkiverse:mainfrom
Open
[Fix #261] Adding JPA persistence plugin#279fjtirado wants to merge 2 commits intoquarkiverse:mainfrom
fjtirado wants to merge 2 commits intoquarkiverse:mainfrom
Conversation
Member
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
That's great that we now have 3 different persistance modules. Can you please add an example for the persistence use case here? https://github.com/quarkiverse/quarkus-flow/tree/main/examples
|
|
||
| @Override | ||
| public void writeStatus(WorkflowContextData workflowContext, WorkflowStatus suspended) { | ||
| find(workflowContext).setStatus(suspended); |
Member
There was a problem hiding this comment.
Why does this var call suspended? Perhaps status? :)
Contributor
Author
There was a problem hiding this comment.
the reason is that right now the only status that is stored is suspended (in other words we only care about the status is the workflow should not be running after restoring)
Member
There was a problem hiding this comment.
If that so you should then check if the value of WorkflowStatus is really suspended.
...nce/jpa/runtime/src/main/java/io/quarkiverse/flow/persistence/jpa/JpaInstanceOperations.java
Show resolved
Hide resolved
persistence/jpa/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Outdated
Show resolved
Hide resolved
…tension.yaml Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #261