Add in-memory WorkflowInstance store#300
Open
mcruzdev wants to merge 3 commits intoquarkiverse:mainfrom
Open
Conversation
fjtirado
reviewed
Mar 9, 2026
core/runtime-dev/src/main/java/io/quarkiverse/flow/devui/FlowInstance.java
Show resolved
Hide resolved
fjtirado
reviewed
Mar 9, 2026
core/runtime-dev/src/main/java/io/quarkiverse/flow/devui/FlowInstance.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Mar 9, 2026
core/runtime-dev/src/main/java/io/quarkiverse/flow/devui/WorkflowInstanceStore.java
Show resolved
Hide resolved
fjtirado
reviewed
Mar 9, 2026
Contributor
fjtirado
left a comment
There was a problem hiding this comment.
I have a lot of doubs about the "duplication" of this with the Persistentt layer for workflow exeuciton recovery (the info to be stored is essentially the same) but the "durability" of the info is different (for restore, the info should be deleted when the workflow completes) while here it should be kept.
I think, to establish a clear seperation, that the WorkflowInstancestore and its companion value object should be moved to runtime-dev
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for workflow instance management in the Dev UI for local development. The main changes include adding an in-memory workflow instance store, exposing new management endpoints via JSON-RPC, and comprehensive tests for these new features. Additionally, the test dependencies are updated to support the new test cases.
Dev UI workflow instance management support:
InMemoryWorkflowInstanceStore, an in-memory, application-scoped implementation ofWorkflowInstanceStorefor development mode, supporting pagination and sorting of workflow instances.ManagementLifecycleListener,InMemoryWorkflowInstanceStore) and exposedManagementLifecycleRPCServiceas a JSON-RPC provider for Dev UI in local development, enabling workflow instance lifecycle management from the UI. [1] [2]Testing and validation:
LifecycleManagementDevUIJsonRPCTestto test workflow instance management features, including pagination, status filtering, and instance retrieval via Dev UI JSON-RPC endpoints.DevUIWorkflowtest workflow to useFuncWorkflowBuilderand added example functions to demonstrate new management capabilities.junit-jupiter,assertj-core) tocore/runtime-dev/pom.xmlfor richer test assertions and support.Runtime integration:
InjectManagementListenerRecorderto inject the management lifecycle listener into the workflow application builder at runtime initialization, ensuring proper management integration in dev mode.Closes feat: Backend for the Management Console dashboard on the devui #118