fix: WorkflowRegistry is not fetching cacheDescriptor#301
fix: WorkflowRegistry is not fetching cacheDescriptor#301ricardozanini merged 5 commits intoquarkiverse:mainfrom
Conversation
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
Thanks! Also, can you please add a test case to validate this change?
- Add a descriptor
- Add a
Flow - Query from devui backend and make sure that the result is 2.
thanks!
core/runtime/src/main/java/io/quarkiverse/flow/internal/WorkflowRegistry.java
Show resolved
Hide resolved
core/runtime/src/main/java/io/quarkiverse/flow/internal/WorkflowRegistry.java
Outdated
Show resolved
Hide resolved
|
I made the adjustment you requested @ricardozanini . Do I have to do a squash commit? |
|
Thanks @matheusandre1 I added one final comment, no you don't need to squash. |
| public Collection<Workflow> allDefinitions() { | ||
| return allDefinitionsMap().values(); | ||
| } |
There was a problem hiding this comment.
@ricardozanini Do we have a clear picture of where we are are going to use all method and where we are going to use allDefinitions method?
To be honest, I'm a bit lost
core/runtime/src/main/java/io/quarkiverse/flow/internal/WorkflowRegistry.java
Outdated
Show resolved
Hide resolved
core/runtime/src/main/java/io/quarkiverse/flow/internal/WorkflowRegistry.java
Outdated
Show resolved
Hide resolved
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
@fjtirado @matheusandre1 AFAIK, the registry, for now, is used only by runtime-dev. Let's keep only one interface to fetch/count for all (definitions + cache). Once we have another requirement, we can review breaking down the interface.
I'll study the possibility to move WorkflowRegistry to runtime-dev package in another PR.
|
@matheusandre1 can you take a look at the test failures? I'm urging to merge this and release a new version - we have a regression with the |
|
🙈 The PR is closed and the preview is expired. |
4 participants
This is Pr Fixes: #299