Skip to content

Conversation

@phillip-kruger
Copy link
Member

This PR is using the logo feature from Dev UI. Waiting for quarkusio/quarkus#48319 to be merged and released.

@phillip-kruger
Copy link
Member Author

@melloware f.y.i

Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I LOVE IT!

@phillip-kruger phillip-kruger marked this pull request as ready for review June 12, 2025 00:09
@phillip-kruger phillip-kruger requested a review from a team as a code owner June 12, 2025 00:09
@phillip-kruger
Copy link
Member Author

I rebased on Quarkus 3.24.0.CR1 that contains the new api

@melloware
Copy link
Contributor

Shouldn't this delete the custom qwc card itself as it's not needed?

@melloware
Copy link
Contributor

Nevermind I see it did was looking ok my phone!

Copy link
Member

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better wait until the change is available in an LTS before merging this in

@melloware
Copy link
Contributor

i need to make this same change on a bunch of my extensions.

@gastaldi
Copy link
Member

gastaldi commented Oct 8, 2025

We can't merge this until the fix in quarkusio/quarkus#50472 lands in 3.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants