-
Notifications
You must be signed in to change notification settings - Fork 12
Use the new logo feature from Dev UI #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@melloware f.y.i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I LOVE IT!
56d191f to
5aa0094
Compare
|
I rebased on Quarkus 3.24.0.CR1 that contains the new api |
|
Shouldn't this delete the custom qwc card itself as it's not needed? |
|
Nevermind I see it did was looking ok my phone! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better wait until the change is available in an LTS before merging this in
|
i need to make this same change on a bunch of my extensions. |
deployment/src/main/java/io/quarkus/jgit/deployment/devui/GiteaDevUIProcessor.java
Show resolved
Hide resolved
Signed-off-by: Phillip Kruger <[email protected]>
|
We can't merge this until the fix in quarkusio/quarkus#50472 lands in 3.27 |
This PR is using the logo feature from Dev UI. Waiting for quarkusio/quarkus#48319 to be merged and released.