Migrate to Quarkus 3.30 and Protobuf Java 4#225
Merged
edeweerd1A merged 1 commit intomainfrom Dec 16, 2025
Merged
Conversation
edeweerd1A
force-pushed
the
protobuf-4
branch
2 times, most recently
from
63e9e2c to
ead5880
Compare
flazarus1A
approved these changes
Dec 16, 2025
| @@ -0,0 +1,14 @@ | |||
| syntax = "proto3"; | |||
There was a problem hiding this comment.
do we need an example with edition = "2024" to confirm proto 4 is really well managed?
Contributor
Author
There was a problem hiding this comment.
- test compatibility with edition = "2024" language level
| */ | ||
| @Override | ||
| public NonFailingCloudEventBuilder withExtension(@NonNull String key, @NonNull String value) { | ||
| public NonFailingCloudEventBuilder withExtension(String key, String value) { |
There was a problem hiding this comment.
will you clarify why @nonnull is no more required?
Contributor
Author
There was a problem hiding this comment.
- clarify removal of nonnull annotations
Contributor
Author
There was a problem hiding this comment.
After inspection of the differences in dependency trees between this PR and the main branch, we can find that the origin is that the jspecify dependency go from a compile scope to a runtime scope in the dependency tree of the protobuf-java-util artifact. Being runtime, we can not use its annotations in the source code.
Fixes #224. Quarkus 3.27 LTS depends on protobuf-java 3.x whilst the latest Quarkus 3.30.3 depends on protobuf-java 4.x. Fortunately the library is backwards-compatible, and we make it support the new GeneratedMessage base class type. The backwards- and forwards-compatibility is tested with 2 new protobuf-binding and 2 corresponding simple processor samples with: * generation of Java classes from a proto file with proto3 syntax and the protoc 3.x tool * generation of Java classes from a proto file with no syntax and edition 2024 and the protoc 4.x tool But eventually, it is still an update of major version of a dependency, so we mark it with a major version change of the extension itself.
edeweerd1A
force-pushed
the
protobuf-4
branch
from
ead5880 to
3b2c944
Compare
ivantchomgue1a
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #224.
Quarkus 3.27 LTS depends on protobuf-java 3.x whilst the latest Quarkus 3.30.3 depends on protobuf-java 4.x. Fortunately the library is backwards-compatible, and we make it support the new GeneratedMessage base class type.
But eventually, it is still an update of major version of a dependency, so we mark it with a major version change of the extension itself.