-
Notifications
You must be signed in to change notification settings - Fork 49
initial weather-kotlin #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
to try out just do example vscode config: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good start, let's add tests and include in CI. It's to do it in separate pr
| class Weather { | ||
| @RestClient | ||
| lateinit var weatherClient: WeatherClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constructor injection and final fields would probably be better
| class Weather { | |
| @RestClient | |
| lateinit var weatherClient: WeatherClient | |
| class Weather( | |
| @RestClient | |
| private val weatherClient: WeatherClient | |
| ) { |
| </executions> | ||
| </plugin> | ||
| <plugin> | ||
| <artifactId>maven-compiler-plugin</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maven compiler should not be needed for kotlin-only build
mkouba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather not add another sample/example app until #201 is resolved.
|
Tests indeed are needed, here they are #231 |
|
Let's also add .mvn/jvm.config file: |
|
@maxandersen @kpavlov What's the status of this PR? |
initial start of a sample in kotlin (works already)