Skip to content

Add support for hot deployment of OpenAPI files in development mode #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

Add support for hot deployment of OpenAPI files in development mode #1106

merged 1 commit into from
Jun 17, 2025

Conversation

@omatheusmesmo
Copy link
Contributor

@omatheusmesmo omatheusmesmo commented Apr 13, 2025

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

Fixes #1071

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@omatheusmesmo omatheusmesmo requested a review from a team as a code owner April 13, 2025 19:30
@mcruzdev
Copy link
Member

mcruzdev commented Apr 14, 2025

Hi @omatheusmesmo thank you for this great contribution. Could you add test for this code?

@omatheusmesmo
Copy link
Contributor Author

omatheusmesmo commented Apr 14, 2025

Hi @omatheusmesmo thank you for this great contribution. Could you add test for this code?

Hi @mcruzdev !

It's done. =D

mcruzdev
mcruzdev approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @omatheusmesmo, I tested here and it is great!

mcruzdev
mcruzdev requested changes Apr 15, 2025
View reviewed changes
Copy link
Member

@mcruzdev mcruzdev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @omatheusmesmo I have tested an scenario:

  • When the user adds the followingquarkus.openapi-generator.moqu.resource-dir=openapi property (not in resources dir) the hot reload does not work.

The Quarkus Roq extension does something similar (watching directory from project root dir).

@omatheusmesmo omatheusmesmo changed the title fix: Add support for hot deployment of OpenAPI files in development mode WIP - Add support for hot deployment of OpenAPI files in development mode Apr 16, 2025
@omatheusmesmo omatheusmesmo marked this pull request as draft April 16, 2025 10:41
@omatheusmesmo
Copy link
Contributor Author

omatheusmesmo commented Apr 16, 2025

Sorry @omatheusmesmo I have tested an scenario:

  • When the user adds the followingquarkus.openapi-generator.moqu.resource-dir=openapi property (not in resources dir) the hot reload does not work.

The Quarkus Roq extension does something similar (watching directory from project root dir).

There's no need to apologize. I'm working on fixing this—thanks for the reference!

@mcruzdev mcruzdev assigned omatheusmesmo and unassigned mcruzdev May 13, 2025
mcruzdev
mcruzdev reviewed Jun 10, 2025
View reviewed changes
Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omatheusmesmo for now I think we can guarantee that when I change just the file content the live reload will work as expected. We can solve the live reload dir changes in another pull request, what do you think?

@omatheusmesmo omatheusmesmo force-pushed the bugfix/moqu-is-not-watching-file-changes branch from c3b7c79 to 4277a9c Compare June 16, 2025 12:19
@omatheusmesmo
Copy link
Contributor Author

omatheusmesmo commented Jun 16, 2025

@omatheusmesmo for now I think we can guarantee that when I change just the file content the live reload will work as expected. We can solve the live reload dir changes in another pull request, what do you think?

Sounds good to me, I can also open a new issue about this bug.

@mcruzdev
Copy link
Member

mcruzdev commented Jun 17, 2025

Thanks a lot for this pull request @omatheusmesmo!
c

ould you set for review and squash all commits? So we can merge this!

@mcruzdev mcruzdev closed this Jun 17, 2025
@mcruzdev mcruzdev reopened this Jun 17, 2025
@mcruzdev
Copy link
Member

mcruzdev commented Jun 17, 2025

Sorry, IDNK why this was closed

@omatheusmesmo omatheusmesmo changed the title WIP - Add support for hot deployment of OpenAPI files in development mode Add support for hot deployment of OpenAPI files in development mode Jun 17, 2025
@omatheusmesmo omatheusmesmo marked this pull request as ready for review June 17, 2025 13:11
@omatheusmesmo omatheusmesmo requested a review from mcruzdev June 17, 2025 13:12
@omatheusmesmo omatheusmesmo force-pushed the bugfix/moqu-is-not-watching-file-changes branch from 28eaa3c to 699d955 Compare June 17, 2025 13:30
@omatheusmesmo omatheusmesmo reopened this Jun 17, 2025
@omatheusmesmo
Copy link
Contributor Author

omatheusmesmo commented Jun 17, 2025

Thanks a lot for this pull request @omatheusmesmo! c

ould you set for review and squash all commits? So we can merge this!

Done! 😄

mcruzdev
mcruzdev approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mcruzdev
Copy link
Member

mcruzdev commented Jun 17, 2025 •
edited
Loading

@ricardozanini @hbelmiro we need to add backporting tag, am i right?

EDIT: We already have.

@mcruzdev mcruzdev merged commit 4ebd047 into quarkiverse:main Jun 17, 2025
21 checks passed
@github-actions github-actions bot mentioned this pull request Jun 17, 2025
Merged
7 tasks
@mcruzdev
Copy link
Member

mcruzdev commented Jun 27, 2025

@all-contributors please add @omatheusmesmo for code

@allcontributors allcontributors bot mentioned this pull request Jun 27, 2025
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Jun 27, 2025

@mcruzdev

I've put up a pull request to add @omatheusmesmo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@mcruzdev mcruzdev mcruzdev approved these changes

@hbelmiro hbelmiro Awaiting requested review from hbelmiro

Assignees

@omatheusmesmo omatheusmesmo

Labels

area:wiremock backport-main-lts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Quarkus OpenAPI Generator Moqu is not watching file changes

4 participants

@omatheusmesmo @mcruzdev @ricardozanini @hbelmiro