Fix #1127 - Use CredentialProvider in OAuth2 provider #1126

gabriel-farache · 2025-04-30T09:45:03Z

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

You have read the contributors guide
Your code is properly formatted according to our code style
Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
Pull Request contains link to the issue
Pull Request contains link to any dependent or related Pull Request
Pull Request contains description of the issue
Pull Request does not include fixes for issues other than the main ticket

This PR solves #1127

introduces tests for the Oauth2 provider (both Classic and Reactive depending on the delegate implementation used)
make use of the newly introduced CredentialProvider interface instance when setting the token in the header

the behaviour is not a get as for the other providers but a set as the access token is first generated by the delegate and then set in the header. The reactive delegate and its Mutiny (async) usage force us to have all in one (getting the token and setting the header) to avoid losing the benefit of releasing the thread while waiting for the token. If we are fine with losing it, a getToken method can instead be defined in the OidcClientRequestFilterDelegate interface and then use it in a CredentialProvider get method for oauth2 instead of calling the filter from the delegate

gabriel-farache · 2025-04-30T10:01:20Z

@ricardozanini PTAL

...time/src/main/java/io/quarkiverse/openapi/generator/providers/ConfigCredentialsProvider.java

...nt/runtime/src/main/java/io/quarkiverse/openapi/generator/providers/CredentialsProvider.java

...t/runtime/src/main/java/io/quarkiverse/openapi/generator/providers/AbstractAuthProvider.java

...time/src/main/java/io/quarkiverse/openapi/generator/providers/ConfigCredentialsProvider.java

...nt/runtime/src/main/java/io/quarkiverse/openapi/generator/providers/CredentialsProvider.java

.../main/java/io/quarkiverse/openapi/generator/oidc/providers/OAuth2AuthenticationProvider.java

...time/src/main/java/io/quarkiverse/openapi/generator/providers/ConfigCredentialsProvider.java

hbelmiro

Thank you @gabriel-farache.

...uth-provider/src/test/java/io/quarkiverse/openapi/generator/it/auth/KeycloakServiceMock.java

...ovider/src/test/java/io/quarkiverse/openapi/generator/it/auth/TokenExternalServicesMock.java

...est/java/io/quarkiverse/openapi/generator/it/auth/TokenWithCustomCredentialProviderTest.java

...est/java/io/quarkiverse/openapi/generator/oidc/ReactiveOAuth2AuthenticationProviderTest.java

ricardozanini · 2025-05-26T21:44:53Z

@gmunozfe mind taking a look?

gabriel-farache · 2025-06-05T19:08:16Z

@ricardozanini should this part of the doc https://github.com/quarkiverse/quarkus-openapi-generator/blob/main/docs/modules/ROOT/pages/includes/custom-auth-provider.adoc?plain=1#L30 be updated? In our IT the priority is higher than the default one and it appears that our custom classes are used instead of the default one

CrendentialProvider Signed-off-by: gabriel-farache <[email protected]>

ricardozanini · 2025-06-05T21:19:01Z

@ricardozanini should this part of the doc https://github.com/quarkiverse/quarkus-openapi-generator/blob/main/docs/modules/ROOT/pages/includes/custom-auth-provider.adoc?plain=1#L30 be updated? In our IT the priority is higher than the default one and it appears that our custom classes are used instead of the default one

Yes, the docs are wrong. I forgot to update on my PR. Can you update it here?

Signed-off-by: gabriel-farache <[email protected]>

gabriel-farache · 2025-06-06T08:51:29Z

@ricardozanini should this part of the doc https://github.com/quarkiverse/quarkus-openapi-generator/blob/main/docs/modules/ROOT/pages/includes/custom-auth-provider.adoc?plain=1#L30 be updated? In our IT the priority is higher than the default one and it appears that our custom classes are used instead of the default one

Yes, the docs are wrong. I forgot to update on my PR. Can you update it here?

done

ricardozanini

@gabriel-farache can you please follow up a new PR with my late considerations? I'm sorry, I've merged too soon.

.../main/java/io/quarkiverse/openapi/generator/oidc/providers/OAuth2AuthenticationProvider.java

...nt/runtime/src/main/java/io/quarkiverse/openapi/generator/providers/CredentialsProvider.java

Signed-off-by: gabriel-farache <[email protected]>

…rkiverse#1126) * Use CredentialProvider in OAUTH2 provider and update data structure for CrendentialProvider Signed-off-by: gabriel-farache <[email protected]> * Fix Custom auth provider doc Signed-off-by: gabriel-farache <[email protected]> --------- Signed-off-by: gabriel-farache <[email protected]>

Signed-off-by: gabriel-farache <[email protected]>

[main-lts] Manually cherry-pick PRs since #1126 (CredentialsProvider feat)

gabriel-farache requested a review from a team as a code owner April 30, 2025 09:45

gabriel-farache force-pushed the fix/oauth2_provider_credentialProvider branch 6 times, most recently from 9cb6610 to 565cdd6 Compare April 30, 2025 09:57

hbelmiro added the backport-main-lts label Apr 30, 2025

ricardozanini self-assigned this Apr 30, 2025

ricardozanini added the area:client This item is related to the client extension label Apr 30, 2025

ricardozanini reviewed Apr 30, 2025

View reviewed changes

...time/src/main/java/io/quarkiverse/openapi/generator/providers/ConfigCredentialsProvider.java Outdated Show resolved Hide resolved

...time/src/main/java/io/quarkiverse/openapi/generator/providers/ConfigCredentialsProvider.java Outdated Show resolved Hide resolved

gabriel-farache force-pushed the fix/oauth2_provider_credentialProvider branch 2 times, most recently from d0c6537 to aad13a7 Compare April 30, 2025 18:54

gabriel-farache changed the title ~~Use CredentialProvider in OAuth2 provider~~ Fix #1127 - Use CredentialProvider in OAuth2 provider Apr 30, 2025

gabriel-farache force-pushed the fix/oauth2_provider_credentialProvider branch 3 times, most recently from 9c48cc2 to a276dfa Compare April 30, 2025 19:07

github-advanced-security bot found potential problems Apr 30, 2025

View reviewed changes

ricardozanini reviewed Apr 30, 2025

View reviewed changes

gabriel-farache force-pushed the fix/oauth2_provider_credentialProvider branch 5 times, most recently from 30d851b to 8483233 Compare April 30, 2025 21:50

github-advanced-security bot found potential problems Apr 30, 2025

View reviewed changes

...nt/runtime/src/main/java/io/quarkiverse/openapi/generator/providers/CredentialsProvider.java Fixed Show fixed Hide fixed

...nt/runtime/src/main/java/io/quarkiverse/openapi/generator/providers/CredentialsProvider.java Fixed Show fixed Hide fixed

gabriel-farache requested a review from ricardozanini May 5, 2025 07:09

ricardozanini reviewed May 5, 2025

View reviewed changes

.../main/java/io/quarkiverse/openapi/generator/oidc/providers/OAuth2AuthenticationProvider.java Show resolved Hide resolved

...time/src/main/java/io/quarkiverse/openapi/generator/providers/ConfigCredentialsProvider.java Outdated Show resolved Hide resolved

gabriel-farache force-pushed the fix/oauth2_provider_credentialProvider branch from 0f1e570 to 6df6a23 Compare May 5, 2025 13:52

gabriel-farache requested a review from ricardozanini May 7, 2025 06:52

hbelmiro approved these changes May 19, 2025

View reviewed changes

gmunozfe reviewed May 20, 2025

View reviewed changes

gabriel-farache force-pushed the fix/oauth2_provider_credentialProvider branch from 11c0b03 to fcbdbf0 Compare May 21, 2025 15:05

gabriel-farache mentioned this pull request May 22, 2025

Custom CredentialProvider class not loaded #1156

Closed

gabriel-farache requested a review from gmunozfe May 26, 2025 07:38

gabriel-farache mentioned this pull request Jun 2, 2025

Fix #1156 - Move AuthProviders SyntheticBean generation to Runtime #1163

Merged

7 tasks

gabriel-farache force-pushed the fix/oauth2_provider_credentialProvider branch 2 times, most recently from 01ff9ab to aaf4919 Compare June 5, 2025 13:36

Use CredentialProvider in OAUTH2 provider and update data structure for

bbd3c5f

CrendentialProvider Signed-off-by: gabriel-farache <[email protected]>

gabriel-farache force-pushed the fix/oauth2_provider_credentialProvider branch from 643f843 to bbd3c5f Compare June 5, 2025 19:15

Fix Custom auth provider doc

bbc907f

Signed-off-by: gabriel-farache <[email protected]>

gmunozfe approved these changes Jun 6, 2025

View reviewed changes

ricardozanini merged commit 8a2fcb3 into quarkiverse:main Jun 6, 2025
11 checks passed

ricardozanini reviewed Jun 6, 2025

View reviewed changes

.../main/java/io/quarkiverse/openapi/generator/oidc/providers/OAuth2AuthenticationProvider.java Show resolved Hide resolved

...nt/runtime/src/main/java/io/quarkiverse/openapi/generator/providers/CredentialsProvider.java Show resolved Hide resolved

gabriel-farache added a commit to gabriel-farache/quarkus-openapi-generator that referenced this pull request Jun 6, 2025

Apply late feedback of PR quarkiverse#1126

d256c04

Signed-off-by: gabriel-farache <[email protected]>

gabriel-farache mentioned this pull request Jun 6, 2025

Fix #1127 - Apply late feedback of PR #1126 #1173

Merged

7 tasks

gabriel-farache deleted the fix/oauth2_provider_credentialProvider branch June 6, 2025 13:35

gabriel-farache added a commit to gabriel-farache/quarkus-openapi-generator that referenced this pull request Jun 6, 2025

Apply late feedback of PR quarkiverse#1126

52ff5d5

Signed-off-by: gabriel-farache <[email protected]>

gabriel-farache added a commit to gabriel-farache/quarkus-openapi-generator that referenced this pull request Jun 6, 2025

Apply late feedback of PR quarkiverse#1126

bb77674

Signed-off-by: gabriel-farache <[email protected]>

gabriel-farache mentioned this pull request Jun 6, 2025

Providers expose constructor without CredentialsProvider arg #1175

Closed

gabriel-farache added a commit to gabriel-farache/quarkus-openapi-generator that referenced this pull request Jun 10, 2025

Apply late feedback of PR quarkiverse#1126

006df17

Signed-off-by: gabriel-farache <[email protected]>

ricardozanini pushed a commit that referenced this pull request Jun 10, 2025

Apply late feedback of PR #1126 (#1173)

75994db

Signed-off-by: gabriel-farache <[email protected]>

ricardozanini pushed a commit to ricardozanini/quarkus-openapi-generator that referenced this pull request Jun 18, 2025

Apply late feedback of PR quarkiverse#1126 (quarkiverse#1173)

6e7a1c5

Signed-off-by: gabriel-farache <[email protected]>

ricardozanini mentioned this pull request Jun 18, 2025

[main-lts] Manually cherry-pick PRs since #1126 (CredentialsProvider feat) #1208

Merged

fjtirado added a commit that referenced this pull request Jun 19, 2025

Merge pull request #1208 from ricardozanini/cp-2.11.0-lts

5462070

[main-lts] Manually cherry-pick PRs since #1126 (CredentialsProvider feat)

Fix #1127 - Use CredentialProvider in OAuth2 provider #1126

Fix #1127 - Use CredentialProvider in OAuth2 provider #1126

Uh oh!

Conversation

gabriel-farache commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabriel-farache commented Apr 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hbelmiro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ricardozanini commented May 26, 2025

Uh oh!

gabriel-farache commented Jun 5, 2025

Uh oh!

ricardozanini commented Jun 5, 2025

Uh oh!

gabriel-farache commented Jun 6, 2025

Uh oh!

Uh oh!

ricardozanini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gabriel-farache commented Apr 30, 2025 •

edited

Loading