Skip to content

Conversation

@cmoine-swi
Copy link
Contributor

@cmoine-swi cmoine-swi commented May 27, 2025

Implement #1160

Expose the option generateBuilders from jsonschema2pojo

@cmoine-swi cmoine-swi requested a review from a team as a code owner May 27, 2025 12:45
@hbelmiro hbelmiro linked an issue May 27, 2025 that may be closed by this pull request
@ricardozanini ricardozanini added the area:server This item is related to the server extension label May 27, 2025
Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @cmoine-swi !
Great work!
Could you add also some integration tests for validating both values:
quarkus.openapi.generator.generate-builders=true/false

@cmoine-swi cmoine-swi force-pushed the Generate-builder-methods-on-beans branch from 6efe4a5 to 5fa7ce6 Compare June 13, 2025 07:48
@cmoine-swi
Copy link
Contributor Author

@gmunozfe Thx, sorry for the delay. Please find the Integration Tests 😉

@ricardozanini ricardozanini requested a review from mcruzdev June 13, 2025 16:46
Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cmoine-swi, thanks a lot for this great feature and sorry for my delay.

I left some comments, could you take a look? Thanks again.

@cmoine-swi cmoine-swi requested a review from mcruzdev June 23, 2025 07:11
@mcruzdev
Copy link
Member

Hi @cmoine-swi!
I think it is close, we need to format:

Imports are not sorted in ApicurioCodegenWrapper.java

Try to run:

mvn -f server net.revelc.code:impsort-maven-plugin:1.12.0:sort

Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @cmoine-swi for your contribution, could you squash all commits in one :)

@mcruzdev mcruzdev requested a review from gmunozfe July 4, 2025 01:17
@cmoine-swi cmoine-swi force-pushed the Generate-builder-methods-on-beans branch from ad51850 to be7821b Compare July 4, 2025 06:54
@mcruzdev mcruzdev merged commit 111931d into quarkiverse:main Jul 4, 2025
11 checks passed
@mcruzdev
Copy link
Member

@all-contributors please add @cmoine-swi for code

@allcontributors
Copy link
Contributor

@mcruzdev

I've put up a pull request to add @cmoine-swi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:server This item is related to the server extension backport-main-lts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate Builder methods on Beans

5 participants