[main-lts] Fixes an issue where the generated REST client was missing a comma #1178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1170) * Fixes an issue where the generated REST client was missing a comma between `additional-request-args` and `@Url` when both were used, causing a compilation error. Updated the `api.qute` template to handle this safely, without affecting other parameter combinations. * test: add test to ensure additionalRequestArgs are generated when length > 0 fix: adjust api.qute to correctly handle commas when using additionalRequestArgs and dynamic url Updated the `api.qute` template to handle this safely, without affecting other parameter combinations. * test: add test to ensure additionalRequestArgs are generated when length > 0 fix: adjust api.qute to correctly handle commas when using additionalRequestArgs and dynamic url Updated the `api.qute` template to handle this safely, without affecting other parameter combinations.
Contributor
Author
|
🎊 PR Preview 75994db has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-1178.surge.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport: #1170
This PR fixes #1161
When using both
additional-request-argsanduse-dynamic-url=true, the generated REST client method was missing a comma between the parameters, causing a compilation error.This update to the
api.qutetemplate ensures that:additionalRequestArgsand@Url