Skip to content

Conversation

@gabriel-farache
Copy link
Contributor

@gabriel-farache gabriel-farache commented Jun 10, 2025

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Fixes #1180

Fixes apache/incubator-kie-issues#1968

@gabriel-farache gabriel-farache requested a review from a team as a code owner June 10, 2025 19:20
@gabriel-farache
Copy link
Contributor Author

@fjtirado @ricardozanini I took the liberty to add some debug logs, I can set them to Trace or even remove them if you don't feel comfortable by having those

Copy link
Contributor

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some traces should be removed beyond the one reported by codeql
Great work @gabriel-farache!!!

@gabriel-farache
Copy link
Contributor Author

I think some traces should be removed beyond the one reported by codeql Great work @gabriel-farache!!!

Yeah...I am only logging the header keys now and never a single header value

Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, excellent work @gabriel-farache !

@gabriel-farache
Copy link
Contributor Author

FYI this will also needs to be backported to LTS

@fjtirado fjtirado merged commit 9d7eb5a into quarkiverse:main Jun 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not all headers are correctly propagated Support authentication propagation for CloudEvents

3 participants