Skip to content

Conversation

@gabriel-farache
Copy link
Contributor

@gabriel-farache gabriel-farache commented Jun 12, 2025

Fixes #1191
Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@gabriel-farache gabriel-farache requested a review from a team as a code owner June 12, 2025 14:35
@gabriel-farache
Copy link
Contributor Author

@wmedvede PTAL

Copy link
Contributor

@wmedvede wmedvede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gabriel-farache I have left some comments, take a look it makes sense please.

@gabriel-farache gabriel-farache requested a review from wmedvede June 17, 2025 08:27
@gabriel-farache gabriel-farache force-pushed the fix_CredentialsProvider_return_optionnal branch from f521b8a to 8006c30 Compare June 17, 2025 08:53
Signed-off-by: gabriel-farache <[email protected]>
@gabriel-farache gabriel-farache force-pushed the fix_CredentialsProvider_return_optionnal branch from 8006c30 to 20397b8 Compare June 17, 2025 13:02
@ricardozanini ricardozanini added the area:client This item is related to the client extension label Jun 17, 2025
@gabriel-farache gabriel-farache force-pushed the fix_CredentialsProvider_return_optionnal branch from f17b39c to 994d161 Compare June 17, 2025 18:33
@ricardozanini ricardozanini merged commit ab2ba32 into quarkiverse:main Jun 18, 2025
11 checks passed
ricardozanini pushed a commit to ricardozanini/quarkus-openapi-generator that referenced this pull request Jun 18, 2025
…kiverse#1192)

* Fix quarkiverse#1191 - refactor CredentialsProvider return type

* Apply feedback

Signed-off-by: gabriel-farache <[email protected]>

* Better log message for oauth2 provider

Signed-off-by: gabriel-farache <[email protected]>

---------

Signed-off-by: gabriel-farache <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:client This item is related to the client extension backport-main-lts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor CredentialsProvider interface to return Optional<String>

4 participants