-
Notifications
You must be signed in to change notification settings - Fork 113
Fix #1210 - use put method to set headers in oauth2 delegate to avoid immutable error #1211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1210 - use put method to set headers in oauth2 delegate to avoid immutable error #1211
Conversation
…te to avoid immutable error Signed-off-by: gabriel-farache <[email protected]>
64c717b to
3e68e5b
Compare
|
cc @wmedvede @fjtirado |
|
https://github.com/quarkiverse/quarkus-openapi-generator/blob/main/client/runtime/src/main/java/io/quarkiverse/openapi/generator/providers/ApiKeyAuthenticationProvider.java#L46 should be fine as we are not working with list |
fjtirado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardozanini This completes #1189
Needs to be included in the upcoming release
ricardozanini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gabriel-farache! Please add a test case to validate the changes.
Signed-off-by: gabriel-farache <[email protected]>
@ricardozanini Done |
...main/java/io/quarkiverse/openapi/generator/oidc/ReactiveOidcClientRequestFilterDelegate.java
Show resolved
Hide resolved
...est/java/io/quarkiverse/openapi/generator/oidc/ReactiveOAuth2AuthenticationProviderTest.java
Show resolved
Hide resolved
|
@hbelmiro, do you have any clues as to why @gabriel-farache's PRs are not being included in the backport automation? 🤔 @gabriel-farache can you please manually cherry-pick this PR to |
|
@gabriel-farache forget it, looks like CI is just lazy today: https://github.com/quarkiverse/quarkus-openapi-generator/actions/runs/15759894794 Keep an eye on it, though. If it fails, we might have to push it manually. |
… immutable error (#1211) * Fix #1210 - use put method to set headers in oauth2 delegate to avoid immutable error Signed-off-by: gabriel-farache <[email protected]> * Add unit test Signed-off-by: gabriel-farache <[email protected]> --------- Signed-off-by: gabriel-farache <[email protected]>
… immutable error (#1211) (#1213) * Fix #1210 - use put method to set headers in oauth2 delegate to avoid immutable error * Add unit test --------- Signed-off-by: gabriel-farache <[email protected]> Co-authored-by: gabriel-farache <[email protected]>
Fixes #1210
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.