Skip to content

Conversation

@mcruzdev
Copy link
Member

Changes

  • Add a new propery called bean-validation that allows the creating of beans and resource with JSR-303
  • Use the apicurio-codegen API for setting builders feature

NOTE

I am waiting the new release from apicurio-codegen side, I recently opened a pull request, see more here.

@mcruzdev mcruzdev requested a review from a team as a code owner July 13, 2025 19:16
@mcruzdev
Copy link
Member Author

fyi: @cmoine-swi

@ricardozanini
Copy link
Member

hmm looks like CI stills red :(

@mcruzdev
Copy link
Member Author

Yeah, we need to wait the new release.

Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a minor comment, good work @mcruzdev !

@mcruzdev
Copy link
Member Author

Sorry @gmunozfe, I will add this one as draft.

@mcruzdev mcruzdev marked this pull request as draft July 17, 2025 12:34
@mcruzdev mcruzdev changed the title Upgrade apicurio-codegen dependency Upgrade apicurio-codegen dependency using bean validation Jul 22, 2025
@mcruzdev mcruzdev marked this pull request as ready for review July 22, 2025 01:27
@mcruzdev
Copy link
Member Author

Waiting the CI for squashing.

@mcruzdev mcruzdev force-pushed the upgrade-apicurio-codegen branch from 7cb0235 to 02851cc Compare July 22, 2025 01:51
Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great work @mcruzdev !

@mcruzdev
Copy link
Member Author

Could I merge it @hbelmiro @ricardozanini?

@hbelmiro
Copy link
Contributor

@mcruzdev feel free to merge it when the CI is green.

@mcruzdev mcruzdev merged commit d000abe into quarkiverse:main Jul 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants