-
Notifications
You must be signed in to change notification settings - Fork 113
Upgrade apicurio-codegen dependency using bean validation #1245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
fyi: @cmoine-swi |
|
hmm looks like CI stills red :( |
|
Yeah, we need to wait the new release. |
gmunozfe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a minor comment, good work @mcruzdev !
.../java/io/quarkiverse/openapi/server/generator/deployment/codegen/ApicurioCodegenWrapper.java
Outdated
Show resolved
Hide resolved
|
Sorry @gmunozfe, I will add this one as draft. |
|
Waiting the CI for squashing. |
7cb0235 to
02851cc
Compare
gmunozfe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great work @mcruzdev !
|
Could I merge it @hbelmiro @ricardozanini? |
|
@mcruzdev feel free to merge it when the CI is green. |
Changes
bean-validationthat allows the creating of beans and resource with JSR-303NOTE
I am waiting the new release from apicurio-codegen side, I recently opened a pull request, see more here.