Skip to content

Conversation

@ameerabdallah
Copy link
Contributor

@ameerabdallah ameerabdallah commented Oct 30, 2025

#1351

  • Adds missing @JsonProperty to setter methods for POJOs
  • Adds unit tests to ensure @JsonProperty does correctly get applied to setter methods and getter methods for POJOs

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@ameerabdallah ameerabdallah requested a review from a team as a code owner October 30, 2025 08:18
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one minor comment.

@ricardozanini ricardozanini merged commit 0f08eca into quarkiverse:main Oct 30, 2025
11 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 30, 2025
* Update templates to support @JsonProperty for setters and add tests for @JsonProperty handling in getters and setters

* Replace qualified names with class import for JsonProperty
ricardozanini added a commit that referenced this pull request Nov 3, 2025
…Os (#1356)

* #1351: Add missing @JsonProperty to setter methods for POJOs (#1355)

* Update templates to support @JsonProperty for setters and add tests for @JsonProperty handling in getters and setters

* Replace qualified names with class import for JsonProperty

* Fix IT test to LTS version

---------

Co-authored-by: Ameer Abdallah <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@JsonProperty not being set on model setters. Same as upstream https://github.com/OpenAPITools/openapi-generator/issues/6856

3 participants