Skip to content

Conversation

@ricardozanini
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

Fix the issue with gav IT tests when doing the release. Instead of syntethic dependencies, we now use the Maven Invoker plugin to install the yaml dependencies before running the tests.

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@ricardozanini
Copy link
Member Author

@michaelsonnleitner please take a look.

@ricardozanini ricardozanini merged commit 12bc163 into quarkiverse:main Nov 4, 2025
11 checks passed
@ricardozanini ricardozanini deleted the fix-yaml-gav branch November 4, 2025 20:39
ricardozanini added a commit to ricardozanini/quarkus-openapi-generator that referenced this pull request Nov 4, 2025
* chore: use invoker plugin on gav IT

Signed-off-by: Ricardo Zanini <[email protected]>

* Adjust gav sub modules order; fix maven compiler plugin

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>
ricardozanini added a commit that referenced this pull request Nov 5, 2025
* chore: use invoker plugin on gav IT (#1361)

* chore: use invoker plugin on gav IT

Signed-off-by: Ricardo Zanini <[email protected]>

* Adjust gav sub modules order; fix maven compiler plugin

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>

* [cherry-pick] chore: use invoker plugin on gav IT

---------

Signed-off-by: Ricardo Zanini <[email protected]>
@michaelsonnleitner
Copy link
Contributor

@ricardozanini i was thinking about the reason of this change. could you explain me why you did that? thx

@ricardozanini
Copy link
Member Author

@michaelsonnleitner Once I did the release, the pipeline failed because the jars weren't added to the graph. So instead of doing that, we are building the test dependencies via invocator and running the tests in an isolated manner.

@michaelsonnleitner
Copy link
Contributor

ok thx. for that info. these tests are very special :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants