Skip to content

Conversation

@ameerabdallah
Copy link
Contributor

@ameerabdallah ameerabdallah commented Nov 7, 2025

[#1369] Add @SuppressWarnings to generated client classes

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@ameerabdallah ameerabdallah requested a review from a team as a code owner November 7, 2025 04:16
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I previously worked on the PR that added @JsonProperty to pojo setters but realized I made the file extension of a json file yaml instead. Kinda breaks one of the checkboxes for the PR ("Pull Request does not include fixes for issues other than the main ticket") so I can pop off this commit if you guys are strict about it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this passed the integration tests then. I wonder if we are trying to parse to JSON first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually took a look at this last night because I was wondering the same thing. I had traced it down to here: https://github.com/swagger-api/swagger-parser/blob/ef2cf163dfdf19af5a5a8dc1ab6651dcfcd43924/modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/DeserializationUtils.java#L245

Looks like it just tries the json parser if the yaml is invalid

Not 100% sure that's actually the reason it still worked since I didn't bother step through with the debugger to verify that this is where it is parsing it, but it's my best guess.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this passed the integration tests then. I wonder if we are trying to parse to JSON first.

@ricardozanini ricardozanini merged commit 1b2c081 into quarkiverse:main Nov 7, 2025
13 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 7, 2025
* [#1369] Add @SuppressWarnings to generated client classes

* Fix openapi file extension
ricardozanini added a commit that referenced this pull request Nov 7, 2025
…1371)

* [#1369] Add @SuppressWarnings to generated client classes (#1370)

* [#1369] Add @SuppressWarnings to generated client classes

* Fix openapi file extension

* Update client/integration-tests/suppress-warnings/pom.xml

---------

Co-authored-by: Ameer Abdallah <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants