-
Notifications
You must be signed in to change notification settings - Fork 113
[#1369] Add @SuppressWarnings to generated client classes #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I previously worked on the PR that added @JsonProperty to pojo setters but realized I made the file extension of a json file yaml instead. Kinda breaks one of the checkboxes for the PR ("Pull Request does not include fixes for issues other than the main ticket") so I can pop off this commit if you guys are strict about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why this passed the integration tests then. I wonder if we are trying to parse to JSON first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually took a look at this last night because I was wondering the same thing. I had traced it down to here: https://github.com/swagger-api/swagger-parser/blob/ef2cf163dfdf19af5a5a8dc1ab6651dcfcd43924/modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/DeserializationUtils.java#L245
Looks like it just tries the json parser if the yaml is invalid
Not 100% sure that's actually the reason it still worked since I didn't bother step through with the debugger to verify that this is where it is parsing it, but it's my best guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why this passed the integration tests then. I wonder if we are trying to parse to JSON first.
* [#1369] Add @SuppressWarnings to generated client classes * Fix openapi file extension
…1371) * [#1369] Add @SuppressWarnings to generated client classes (#1370) * [#1369] Add @SuppressWarnings to generated client classes * Fix openapi file extension * Update client/integration-tests/suppress-warnings/pom.xml --------- Co-authored-by: Ameer Abdallah <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
[#1369] Add @SuppressWarnings to generated client classes
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.