Skip generation if spec is unchanged#1514
Open
CodeSimcoe wants to merge 1 commit intoquarkiverse:mainfrom
Open
Skip generation if spec is unchanged#1514CodeSimcoe wants to merge 1 commit intoquarkiverse:mainfrom
CodeSimcoe wants to merge 1 commit intoquarkiverse:mainfrom
Conversation
mcruzdev
reviewed
Apr 2, 2026
...in/java/io/quarkiverse/openapi/generator/deployment/codegen/OpenApiGeneratorCodeGenBase.java
Outdated
Show resolved
Hide resolved
Member
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
Looks good! Many thanks for taking your time to help us :)
...in/java/io/quarkiverse/openapi/generator/deployment/codegen/OpenApiGeneratorCodeGenBase.java
Outdated
Show resolved
Hide resolved
mcruzdev
reviewed
Apr 2, 2026
...in/java/io/quarkiverse/openapi/generator/deployment/codegen/OpenApiGeneratorCodeGenBase.java
Outdated
Show resolved
Hide resolved
mcruzdev
reviewed
Apr 2, 2026
...in/java/io/quarkiverse/openapi/generator/deployment/codegen/OpenApiGeneratorCodeGenBase.java
Outdated
Show resolved
Hide resolved
mcruzdev
requested changes
Apr 2, 2026
Member
mcruzdev
left a comment
mcruzdev
left a comment
There was a problem hiding this comment.
Thanks a lot for this pull request @CodeSimcoe 👍🏼
I left a few comments, see if makes sense 😃
Contributor
Author
|
I've made some changes, should be much simpler in terms of configuration management |
mcruzdev
approved these changes
Apr 7, 2026
Member
|
Hey @CodeSimcoe thanks for the new updates, could you squash and to solve the conflicts? |
CodeSimcoe
force-pushed
the
skip-if-unchanged
branch
2 times, most recently
from
532daef to
8e4eb98
Compare
CodeSimcoe
force-pushed
the
skip-if-unchanged
branch
from
8e4eb98 to
4a06119
Compare
Contributor
Author
Should be good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposition to address #878
Skip generation if :
falsefor now, for compatibility reasons)