Skip to content

feat: Add support for ClientMultipartForm#1515

Open
matheusandre1 wants to merge 6 commits intoquarkiverse:mainfrom
matheusandre1:feature/1426
Open

feat: Add support for ClientMultipartForm#1515
matheusandre1 wants to merge 6 commits intoquarkiverse:mainfrom
matheusandre1:feature/1426

Conversation

@matheusandre1
Copy link
Copy Markdown
Contributor

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue Closes: Add support for ClientMultipartForm #1426
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@matheusandre1 matheusandre1 marked this pull request as ready for review April 1, 2026 18:42
@matheusandre1 matheusandre1 requested a review from a team as a code owner April 1, 2026 18:42
Copy link
Copy Markdown
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matheusandre1 It looks really great, could you add an integration-tests with the application.properties enabling this feature?

I tried this one in a custom project, but without success, I need more time to investigate... with an integration-tests we can get the issue.

The integration-tests should be a new module like in https://github.com/quarkiverse/quarkus-openapi-generator/tree/main/client/integration-tests testing your changes.

@matheusandre1
Copy link
Copy Markdown
Contributor Author

Okay, put that into draft then, I'll send a PR of the changes later.

@mcruzdev
Copy link
Copy Markdown
Member

mcruzdev commented Apr 2, 2026

No worries,it is solid and clear!

@mcruzdev
Copy link
Copy Markdown
Member

mcruzdev commented Apr 7, 2026

Hey guy! Looking the CI I think we need two profiles:

<profile>
      <id>resteasy-reactive</id>
      <dependencies>
        <dependency>
          <groupId>io.quarkus</groupId>
          <artifactId>quarkus-rest-client-jackson</artifactId>
        </dependency>
      </dependencies>
    </profile>
    <profile>
      <id>resteasy-classic</id>
      <activation>
        <activeByDefault>true</activeByDefault>
      </activation>
      <dependencies>
        <dependency>
          <groupId>io.quarkus</groupId>
          <artifactId>quarkus-resteasy-client-oidc-filter</artifactId>
        </dependency>
        <dependency>
          <groupId>io.quarkus</groupId>
          <artifactId>quarkus-resteasy-multipart</artifactId>
        </dependency>
      </dependencies>
    </profile>

Additionally, you need to add to add a dependency with the test scope:

    <dependency>
      <groupId>io.quarkus</groupId>
      <artifactId>quarkus-rest-client-jackson</artifactId>
      <scope>test</scope>
    </dependency>

@mcruzdev
Copy link
Copy Markdown
Member

mcruzdev commented Apr 7, 2026

The CI error is relate (see), probably now the error is on test side.

@matheusandre1
Copy link
Copy Markdown
Contributor Author

crazy lol

@matheusandre1
Copy link
Copy Markdown
Contributor Author

quarkus-rest-client-jackson needs to be a normal module dependency, not a test-scoped one.

@matheusandre1 matheusandre1 requested a review from mcruzdev April 7, 2026 04:45
Copy link
Copy Markdown
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @matheusandre1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for ClientMultipartForm

2 participants