feat: Add support for ClientMultipartForm#1515
feat: Add support for ClientMultipartForm#1515matheusandre1 wants to merge 6 commits intoquarkiverse:mainfrom
Conversation
docs/modules/ROOT/pages/includes/sending-multipart-formdata.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@matheusandre1 It looks really great, could you add an integration-tests with the application.properties enabling this feature?
I tried this one in a custom project, but without success, I need more time to investigate... with an integration-tests we can get the issue.
The integration-tests should be a new module like in https://github.com/quarkiverse/quarkus-openapi-generator/tree/main/client/integration-tests testing your changes.
|
Okay, put that into draft then, I'll send a PR of the changes later. |
|
No worries,it is solid and clear! |
7c09c98 to
0dd638f
Compare
…st-client-reactive-jackson
|
Hey guy! Looking the CI I think we need two profiles: <profile>
<id>resteasy-reactive</id>
<dependencies>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-rest-client-jackson</artifactId>
</dependency>
</dependencies>
</profile>
<profile>
<id>resteasy-classic</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<dependencies>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy-client-oidc-filter</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy-multipart</artifactId>
</dependency>
</dependencies>
</profile>Additionally, you need to add to add a dependency with the <dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-rest-client-jackson</artifactId>
<scope>test</scope>
</dependency> |
|
The CI error is relate (see), probably now the error is on test side. |
|
crazy lol |
|
quarkus-rest-client-jackson needs to be a normal module dependency, not a test-scoped one. |
mcruzdev
left a comment
There was a problem hiding this comment.
Thanks for this contribution @matheusandre1
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.