Skip to content

Conversation

@mcruzdev
Copy link
Member

@mcruzdev mcruzdev commented Oct 23, 2024

Why

This pull request aims to add a new module where we get a OpenAPI Specification and transform it to a Wiremock (this pull request, we can have more after) stubs.

This was created from this Discussion: #575

DevUI

Screen.Recording.2024-11-20.at.13.18.08.mov

@melloware
Copy link
Contributor

This is interesting but i don't see any Doc updates explaining what this exactly does?

@mcruzdev
Copy link
Member Author

Hi @melloware, yeah I need to add documentation ;/ I will try to do it on this week.

Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@mcruzdev mcruzdev marked this pull request as ready for review November 20, 2024 16:36
@mcruzdev mcruzdev requested a review from a team as a code owner November 20, 2024 16:36
@mcruzdev
Copy link
Member Author

mcruzdev commented Nov 20, 2024

Could you add your review too? @ricardozanini @hbelmiro @rmanibus @fjtirado

There are some things to do yet, but we can do in another step.

  • Generate wiremock-mappings.json on output directory.
  • Add a DevService for hosting the Wiremock for test/dev purpose (maybe to integrate with quarkisver-wiremock)

@mcruzdev
Copy link
Member Author

cc: @chberger

@ricardozanini
Copy link
Member

Do we have an issue explaining the motivations of this PR?

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems a huge amount of work, thank you!

I won't micro review it, I'd rather wait for community's feedback and traction. My only concern is about this addition to this ecosystem, a comprehensive documentation and README updates to differentiate between the modules. Can we work on these?

Why can't we have just the three sets of projects:

moqu
-- core
-- deployment
-- runtime

I don't the need to split the extension into yet another parent POM.

@mcruzdev
Copy link
Member Author

Do we have an issue explaining the motivations of this PR?

This is related to this discussion #575

@fjtirado fjtirado self-requested a review November 22, 2024 11:41
Copy link
Contributor

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some leftovers that requires cleaning before merging.

@github-actions
Copy link
Contributor

@ricardozanini @hbelmiro This is being labeled as Stale.

@github-actions github-actions bot added the Stale label Jan 21, 2025
@ricardozanini
Copy link
Member

@mcruzdev I'd like to include this extension, but it looks like you are still working on it or...?

@mcruzdev
Copy link
Member Author

mcruzdev commented Jan 21, 2025

@mcruzdev I'd like to include this extension, but it looks like you are still working on it or...?

This is the first version, it is available for reviewing. I need to apply the @fjtirado suggestions

@github-actions github-actions bot removed the Stale label Jan 22, 2025
@mcruzdev
Copy link
Member Author

mcruzdev commented Feb 18, 2025

Hi @ricardozanini @hbelmiro @fjtirado suggestions applied, could you take a review? I would like to add strength to this this year, I've been thinking about this for a while and I always put it off.

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool! Congrats man, I just left a few minor comments.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcruzdev can you please rebase?

@mcruzdev mcruzdev force-pushed the mock-module branch 2 times, most recently from bc58e6f to c83a536 Compare March 11, 2025 12:39
@ricardozanini
Copy link
Member

Do we have enough to merge and move on?

@ricardozanini
Copy link
Member

@fjtirado can you please give a second look? I guess we are waiting for your vote :)

@fjtirado fjtirado merged commit a963396 into quarkiverse:main Mar 19, 2025
7 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 19, 2025
Add moqu and wiremock module
hbelmiro added a commit that referenced this pull request Mar 20, 2025
* Merge pull request #826 from mcruzdev/mock-module

Add moqu and wiremock module

* Fixed versions

Signed-off-by: Helber Belmiro <[email protected]>

---------

Signed-off-by: Helber Belmiro <[email protected]>
Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Co-authored-by: Helber Belmiro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants