-
Notifications
You must be signed in to change notification settings - Fork 113
Add moqu and wiremock module #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is interesting but i don't see any Doc updates explaining what this exactly does? |
|
Hi @melloware, yeah I need to add documentation ;/ I will try to do it on this week. |
melloware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
cfe368a to
e09257d
Compare
|
Could you add your review too? @ricardozanini @hbelmiro @rmanibus @fjtirado There are some things to do yet, but we can do in another step.
|
|
cc: @chberger |
|
Do we have an issue explaining the motivations of this PR? |
ricardozanini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems a huge amount of work, thank you!
I won't micro review it, I'd rather wait for community's feedback and traction. My only concern is about this addition to this ecosystem, a comprehensive documentation and README updates to differentiate between the modules. Can we work on these?
Why can't we have just the three sets of projects:
moqu
-- core
-- deployment
-- runtime
I don't the need to split the extension into yet another parent POM.
This is related to this discussion #575 |
fjtirado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some leftovers that requires cleaning before merging.
moqu/core/src/main/java/io/quarkiverse/openapi/moqu/marshall/ObjectMapperFactory.java
Outdated
Show resolved
Hide resolved
moqu/core/src/main/java/io/quarkiverse/openapi/moqu/model/Header.java
Outdated
Show resolved
Hide resolved
moqu/core/src/main/java/io/quarkiverse/openapi/moqu/model/Request.java
Outdated
Show resolved
Hide resolved
moqu/core/src/test/java/io/quarkiverse/openapi/moqu/Testing.java
Outdated
Show resolved
Hide resolved
|
@ricardozanini @hbelmiro This is being labeled as Stale. |
|
@mcruzdev I'd like to include this extension, but it looks like you are still working on it or...? |
|
Hi @ricardozanini @hbelmiro @fjtirado suggestions applied, could you take a review? I would like to add strength to this this year, I've been thinking about this for a while and I always put it off. |
d8db703 to
6bfe6cf
Compare
ricardozanini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super cool! Congrats man, I just left a few minor comments.
moqu/deployment/src/main/java/io/quarkiverse/openapi/generator/MoquProjectProcessor.java
Outdated
Show resolved
Hide resolved
hbelmiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcruzdev can you please rebase?
bc58e6f to
c83a536
Compare
|
Do we have enough to merge and move on? |
|
@fjtirado can you please give a second look? I guess we are waiting for your vote :) |
Add moqu and wiremock module
* Merge pull request #826 from mcruzdev/mock-module Add moqu and wiremock module * Fixed versions Signed-off-by: Helber Belmiro <[email protected]> --------- Signed-off-by: Helber Belmiro <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: Helber Belmiro <[email protected]>
Why
This pull request aims to add a new module where we get a OpenAPI Specification and transform it to a Wiremock (this pull request, we can have more after) stubs.
This was created from this Discussion: #575
DevUI
Screen.Recording.2024-11-20.at.13.18.08.mov