-
Notifications
You must be signed in to change notification settings - Fork 113
Add validation when the input-base-dir is not present #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a700976 to
b9a8d5e
Compare
ricardozanini
approved these changes
Jan 6, 2025
Member
hbelmiro
reviewed
Jan 19, 2025
Contributor
hbelmiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mcruzdev.
Looks good. I just left a few nits.
...deployment/src/test/java/io/quarkiverse/openapi/server/generator/deployment/CodegenTest.java
Outdated
Show resolved
Hide resolved
...io/quarkiverse/openapi/server/generator/deployment/codegen/ApicurioOpenApiServerCodegen.java
Outdated
Show resolved
Hide resolved
...io/quarkiverse/openapi/server/generator/deployment/codegen/ApicurioOpenApiServerCodegen.java
Outdated
Show resolved
Hide resolved
…generator/deployment/CodegenTest.java Co-authored-by: Helber Belmiro <[email protected]>
…generator/deployment/codegen/ApicurioOpenApiServerCodegen.java Co-authored-by: Helber Belmiro <[email protected]>
…generator/deployment/codegen/ApicurioOpenApiServerCodegen.java Co-authored-by: Helber Belmiro <[email protected]>
hbelmiro
approved these changes
Jan 21, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Add some validations for server configs * Update server/deployment/src/test/java/io/quarkiverse/openapi/server/generator/deployment/CodegenTest.java Co-authored-by: Helber Belmiro <[email protected]> * Update server/deployment/src/main/java/io/quarkiverse/openapi/server/generator/deployment/codegen/ApicurioOpenApiServerCodegen.java Co-authored-by: Helber Belmiro <[email protected]> * Update server/deployment/src/main/java/io/quarkiverse/openapi/server/generator/deployment/codegen/ApicurioOpenApiServerCodegen.java Co-authored-by: Helber Belmiro <[email protected]> --------- Co-authored-by: Helber Belmiro <[email protected]>
7 tasks
ricardozanini
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Add some validations for server configs * Update server/deployment/src/test/java/io/quarkiverse/openapi/server/generator/deployment/CodegenTest.java * Update server/deployment/src/main/java/io/quarkiverse/openapi/server/generator/deployment/codegen/ApicurioOpenApiServerCodegen.java * Update server/deployment/src/main/java/io/quarkiverse/openapi/server/generator/deployment/codegen/ApicurioOpenApiServerCodegen.java --------- Co-authored-by: Matheus Cruz <[email protected]> Co-authored-by: Helber Belmiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Fixes #871
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectI am not sure if this pull request solves the issue, but I think that shows a better message.
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.