Skip to content

Conversation

@mcruzdev
Copy link
Member

@mcruzdev mcruzdev commented Jan 18, 2025

Many thanks for submitting your Pull Request ❤️!

Fixes ##793

This pull request convert the extension to use the new way to configure a extension. This pull request follows the migration guide, removing the need to use the following option:

<compilerArgs><arg>-AlegacyConfigRoot=true</arg>

Additionaly, I change the security configuration to be RUNTIME phase.

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@mcruzdev mcruzdev requested a review from a team as a code owner January 18, 2025 04:04
@mcruzdev mcruzdev added area:server This item is related to the server extension area:client This item is related to the client extension labels Jan 18, 2025
@ricardozanini
Copy link
Member

@mcruzdev can you please rebase and incorporate the comments so we can do a release ASAP?

@mcruzdev
Copy link
Member Author

@mcruzdev can you please rebase and incorporate the comments so we can do a release ASAP?

Of course, doing here...

@mcruzdev mcruzdev force-pushed the config-oapi branch 2 times, most recently from acbc80e to f2de433 Compare January 21, 2025 20:55
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardozanini
Copy link
Member

Once @hbelmiro approves, we can release the new version.

@hbelmiro hbelmiro merged commit a940d82 into quarkiverse:main Jan 22, 2025
7 checks passed
hbelmiro pushed a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:client This item is related to the client extension area:server This item is related to the server extension backport-main-lts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants