Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 4, 2025

Backport: #978

Note: CI is not automatically triggered on backported PRs, please comment 'ok to test' to launch Jenkins jobs

Fixed #976

This PR fixes a condition in the api.qute template that was making the generated endpoint parameters not include the jakarta constrain annotations when use-bean-validation was true.

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…nnotations to all endpoint parameters (#978)

* [issues#964] Fix beanValidationCore.qute condition to include the jakarta.validation.Valid annotation

* [issues#976] Fix api.qute condition to include constraint annotations to all endpoint params
@github-actions github-actions bot requested a review from a team as a code owner February 4, 2025 11:28
@hbelmiro hbelmiro closed this Feb 4, 2025
@hbelmiro hbelmiro reopened this Feb 4, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 4, 2025

🎊 PR Preview b0b8bbc has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-980.surge.sh

@hbelmiro hbelmiro merged commit 5be04c7 into main-lts Feb 4, 2025
12 checks passed
@hbelmiro hbelmiro deleted the main-lts_main branch February 4, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants