[Fix #991] Changing URLPatternMatcher implementation #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
force-pushed
the
Fix_#991
branch
3 times, most recently
from
f660e74 to
7057584
Compare
gmunozfe
reviewed
Feb 18, 2025
| private static Stream<Arguments> providePathsThatNotMatch() { | ||
| return Stream.of( | ||
| Arguments.of("/pets/{id}", "/pes/1"), | ||
| Arguments.of("/{id}/pepe", "/1/2/pep")); |
Contributor
There was a problem hiding this comment.
In this case it doesn't match because "pep" vs "pepe", but however
Arguments.of("/{id}/pepe", "/1/2/pepe"));
matches, is it correct? The placeholder should only contain one id, not two, wdyt?
masayag
added a commit
to rhdhorchestrator/orchestrator-demo
that referenced
this pull request
Feb 18, 2025
The jar file was created based on PR quarkiverse/quarkus-openapi-generator#992 to solve an issue with URL matching.
ricardozanini
approved these changes
Feb 18, 2025
ricardozanini
pushed a commit
that referenced
this pull request
Feb 18, 2025
Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #991