feat: Show generic avatar when there is no one#691
feat: Show generic avatar when there is no one#691matheusandre1 wants to merge 3 commits intoquarkiverse:mainfrom
Conversation
roq-theme/default/src/main/resources/templates/theme-layouts/roq-default/post.html
Outdated
Show resolved
Hide resolved
roq-theme/default/src/main/resources/templates/theme-layouts/roq-default/post.html
Outdated
Show resolved
Hide resolved
mcruzdev
left a comment
mcruzdev
left a comment
There was a problem hiding this comment.
Thanks a lot for this pull request @matheusandre1, I added a few comments. I think that the CI issue is related to the first comment
|
🚀 PR Preview for blog and docs ea4e7fe has been successfully built! |
|
modifications made |
roq-theme/default/src/main/resources/templates/theme-layouts/roq-default/post.html
Outdated
Show resolved
Hide resolved
|
Would it be correct like this, or would I have to include the entire path from the roq-theme? |
|
I didn't identify any functionality for this, I had to implement it myself. |
ia3andy
left a comment
ia3andy
left a comment
There was a problem hiding this comment.
Ok this is very close, you should instead of scanThemeAttachments name it scanResourceSiteAttachments and scan in:
- if(roqProject.isRoqResourcesInRoot) roqProject.consumePathFromRoqResourceDir(config.publicDir()
- visitRuntimeResources(config.publicDir())
No need to scan the static dir.
Also make sure to use a specific dir for example:
public/images/roq-default/default-avatar.svg
matheusandre1
force-pushed
the
issue497
branch
from
e6051df to
dadf182
Compare
|
Can we merge this? |
|
After the the sanner pr |
| if (isIndex) { | ||
| attachments = new ArrayList<>(); | ||
| if (isSiteIndex) { | ||
| // Support legacy static dir |
There was a problem hiding this comment.
Don't we support static dir anymore ?
4 participants
Closes: #497 done.
Show generic avatar when there is no one