Add CommonHaus logo to footer #3246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holly-cummins
force-pushed
the
add-commonhaus-footer
branch
from
5ca5a1d to
00e7c88
Compare
holly-cummins
force-pushed
the
add-commonhaus-footer
branch
from
00e7c88 to
f234acf
Compare
Member
|
Am I supposed to check it out? I'd gladly take your PRs on trust |
Sanne
approved these changes
Jul 28, 2025
Collaborator
Author
My thinking was just to look at the preview, but the surge preview got broken in CI, and then I fixed that but didn't have time to rebase this to trigger the preview, and also didn't have time to comment on the issue to explain that the preview was missing and I didn't really expect you to read my css and mentally render it. :) Sorry, @Sanne ! |
holly-cummins
force-pushed
the
add-commonhaus-footer
branch
from
f234acf to
3535b48
Compare
|
🙈 The PR is closed and the preview is expired. |
Member
Glad to hear that ! :) np, was just wondering how you prefer things |
Member
|
N.B. I don't have merge permissions on this repo, leaving that to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a pixel-perfect match for the main site, but I think once quarkusio/quarkusio.github.io#2365 for the vertical alignment and another PR to fix the font-weight of the links is done, it will be.
It's easiest to see the footer on individual extension pages rather than scrolling through 700 extensions. :)