Add a more complex CRUD example based on the Super Heroes Villain service #1523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice This is mostly intended for (native) performance tracking
zakkak
reviewed
May 29, 2025
Contributor
zakkak
left a comment
zakkak
left a comment
There was a problem hiding this comment.
@cescoffier it LGTM but I am a bit concerned about the use of virtual threads. Do we indeed expect this to be the most common scenario?
I also added a note about the duplicated tets.
| import static org.hamcrest.CoreMatchers.notNullValue; | ||
|
|
||
| @QuarkusIntegrationTest | ||
| public class MoviesEndpointIT { |
Contributor
There was a problem hiding this comment.
@cescoffier why is this class duplicating MoviesEndpointTest, shouldn't it just be:
Suggested change
| public class MoviesEndpointIT { | |
| public class MoviesEndpointIT extends MoviesEndpointTest { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.