-
Notifications
You must be signed in to change notification settings - Fork 3k
Add Jakarta Data documentation, dependency management and tests #47012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jakarta Data documentation, dependency management and tests #47012
Conversation
This comment has been minimized.
This comment has been minimized.
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
3eb68a0 to
b4493ca
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
FroMage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll defer approuval to @yrodiere
b4493ca to
e2690a8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e2690a8 to
0f15ddc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yrodiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll defer approuval to @yrodiere
A few comments below, but I'm approuving. Thank you!
Feel free to address what you agree with, then let's merge.
Baguette, omelette au fromage.
0f15ddc to
cc55044
Compare
|
thanks 😃 |
Status for workflow
|
Status for workflow
|
fixes #44278
I wasn't sure if we should just add the tests to the
hibernate-orm-jpamodelgenhence.. I kept the one in the new module as close to thehibernate-orm-jpamodelgenso that if we decide to merge them in that module, it'll be easier.I've tested the config for the gradle doc example on a test project and this bit:
seems to help with the version management for the AP in the Gradle case.
A quickstart draft PR is here: quarkusio/quarkus-quickstarts#1516