-
Notifications
You must be signed in to change notification settings - Fork 3k
Bump Hibernate Reactive from 2.4.5.Final to 2.4.6.Final #47251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR. Also, obviously, CI is failing :) Could you have a look? It look like a Java Service needs to be registered: Thanks. |
|
Mmmh... I have no idea what I need to do to solve this. Hibernate Reactive implements the |
It's not Quarkus, it's GraalVM. Native compilation requires that you register services that should be made available at runtime. It's basically just like reflection -- and in a way, Java Services are reflection. Go to Lines 168 to 175 in 88c17da
You would need something similar in Hibernate Reactive. |
By the way, I meant you need something similar to the first part ( |
|
@DavideD let me know if you want me to take care of it! |
:] |
|
What do you mean? I only copied the class name, but the list contains only the Vert.x Provider: public static final List<DotName> SERVICE_PROVIDERS = List.of(
// This is a Vert.x service that it's used in in org.hibernate.reactive.context.impl.VertxContext#contextualDataMap
createConstant( "io.vertx.core.spi.VertxServiceProvider" )
);Or did you mean something else? |
This comment has been minimized.
This comment has been minimized.
|
Ah, you refer to the call to |
7df2782 to
4502285
Compare
This comment has been minimized.
This comment has been minimized.
4502285 to
ded306f
Compare
yrodiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
...yment/src/main/java/io/quarkus/hibernate/reactive/deployment/HibernateReactiveProcessor.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
ef6ef4b to
45f5eaa
Compare
This comment has been minimized.
This comment has been minimized.
45f5eaa to
c273c13
Compare
This comment has been minimized.
This comment has been minimized.
c273c13 to
9c32432
Compare
|
@DavideD https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#using-aliases might be of help. The |
This comment has been minimized.
This comment has been minimized.
This seems to be failing all over the place in other PRs... I'll rebase on main and see what happens. |
Hibernate Reactive now implements a service from Vert.x that needs to be registered. Service name : `io.vertx.core.spi.VertxServiceProvider` Implementation: `org.hibernate.reactive.context.impl.ContextualDataStorage`
9c32432 to
55eb518
Compare
Status for workflow
|
|
Thanks! Will backport it in the next backport round. |
|
Let's make sure we bump to 2.4.7 when we include this one in 3.20. |
Fix #46917