-
Notifications
You must be signed in to change notification settings - Fork 3k
Add LRA Dev Services #49175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add LRA Dev Services #49175
Conversation
5c59b78
to
0912fad
Compare
2ec0949
to
74bea09
Compare
Nice!
I don't personally know a better way, but indeed try asking around on zulip to see if we have an explicit way to export reachability to services, that sounds useful as a general feature. However I believe that |
If you are on Mac or Windows, even 0.0.0.0 won't work. You need to use some podman/docker specific hacks to access the host (host.containers.internal in podman, host.docker.internal in docker) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment about accessing the host
74bea09
to
7bcf9d9
Compare
This comment has been minimized.
This comment has been minimized.
@cescoffier this is already done in this PR. Can someone on Mac or Windows verify this PR with this example - https://github.com/xstefank/lra-dev-services-example? |
7bcf9d9
to
68a63da
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@cmoulliard verified it works on Mac. Big thanks! |
68a63da
to
f02c3d5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f02c3d5
to
8a1820d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
8a1820d
to
e67d522
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e67d522
to
2c5c47b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2c5c47b
to
f0aeece
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
.../io/quarkus/narayana/lra/deployment/devservice/LRACoordinatorDevServicesBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
.../io/quarkus/narayana/lra/deployment/devservice/LRACoordinatorDevServicesBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
...ent/src/main/java/io/quarkus/narayana/lra/deployment/devservice/DevServicesLRAProcessor.java
Outdated
Show resolved
Hide resolved
f0aeece
to
904189f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
904189f
to
213281d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
213281d
to
508bcf1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just 2 minor comments.
It would be great to get @ozangunalp review of the dev service code.
.../io/quarkus/narayana/lra/deployment/devservice/LRACoordinatorDevServicesBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
tcks/microprofile-lra/src/main/java/io/quarkus/tck/lra/LRACoordinatorManager.java
Show resolved
Hide resolved
508bcf1
to
be0d97e
Compare
This comment has been minimized.
This comment has been minimized.
be0d97e
to
8b76637
Compare
Status for workflow
|
Status for workflow
|
Fixes #23558
Fixes #18425
Needs a new release of LRA that I'm waiting for, thus opening a Draft for review. Mainly if we can use
quarkus.http.host=0.0.0.0
for the Dev Services or if someone knows a better way to handle container -> app calls.