Skip to content

Conversation

xstefank
Copy link
Member

Fixes #23558
Fixes #18425

Needs a new release of LRA that I'm waiting for, thus opening a Draft for review. Mainly if we can use quarkus.http.host=0.0.0.0 for the Dev Services or if someone knows a better way to handle container -> app calls.

Copy link

github-actions bot commented Jul 30, 2025

😭 Deploy PR Preview failed.

@xstefank xstefank force-pushed the lra-dev-service branch 2 times, most recently from 2ec0949 to 74bea09 Compare July 31, 2025 12:58
@xstefank xstefank requested review from cescoffier and gsmet August 1, 2025 04:45
@xstefank xstefank marked this pull request as ready for review August 7, 2025 06:17
@xstefank xstefank marked this pull request as draft August 7, 2025 06:18
@Sanne
Copy link
Member

Sanne commented Aug 7, 2025

Nice!

Mainly if we can use quarkus.http.host=0.0.0.0 for the Dev Services or if someone knows a better way to handle container

I don't personally know a better way, but indeed try asking around on zulip to see if we have an explicit way to export reachability to services, that sounds useful as a general feature.

However I believe that 0.0.0.0 is actually the default: perhaps rather than adding a scary notice to the docs, and changing settings which aren't this extension's responsibility, it would be best to rely on the defaults and check that this hasn't been set to something else? You could throw an exception with a clear, actionable suggestion in case it was changed.

@cescoffier
Copy link
Member

If you are on Mac or Windows, even 0.0.0.0 won't work. You need to use some podman/docker specific hacks to access the host (host.containers.internal in podman, host.docker.internal in docker)

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about accessing the host

@xstefank xstefank marked this pull request as ready for review August 19, 2025 07:40

This comment has been minimized.

@xstefank
Copy link
Member Author

@cescoffier this is already done in this PR. Can someone on Mac or Windows verify this PR with this example - https://github.com/xstefank/lra-dev-services-example?

This comment has been minimized.

This comment has been minimized.

@xstefank
Copy link
Member Author

xstefank commented Aug 19, 2025

@cmoulliard verified it works on Mac. Big thanks!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@xstefank xstefank requested a review from cescoffier August 20, 2025 10:26

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just 2 minor comments.

It would be great to get @ozangunalp review of the dev service code.

This comment has been minimized.

Copy link

quarkus-bot bot commented Sep 2, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8b76637.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

Copy link

quarkus-bot bot commented Sep 2, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 8b76637.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DevService for LRA Implement Dev Services for the LRA coordinator
4 participants