-
Notifications
You must be signed in to change notification settings - Fork 3k
Preserve active request on subscriber when using messaging-kotlin #49308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve active request on subscriber when using messaging-kotlin #49308
Conversation
fyi @geoand |
Thanks! I'm on PTO so won't be able to have a look at this for the coming few weeks |
Status for workflow
|
Status for workflow
|
🎊 PR Preview fc7d4cb has been successfully built and deployed to https://quarkus-pr-main-49308-preview.surge.sh/version/main/guides/
|
Ha, I'm on PTO too, couple of weeks is fine. No rush. |
Back from PTO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the great tests
Thanks @ozangunalp ! @LarsSven this get's us half way there to getting context propagation working with quarkus-messaging. |
Thanks so much! |
This PR makes changes to the messaging subscriber's Kotlin VertxDispatcher so that the active request is preserved between any possible suspend/resume that could happen in the user's code.
Tests were added, some of which would fail without these changes