Qute: gizmo2 rewrite

[mkouba]

TODO

• Run qute-benchmarks (I only did a quick local run but didn't notice a significant regression)
• Verify dependent Quarkiverse projects
  • qute-web
  • roq
  • Renarde

[mkouba]

We need to wait for Gizmo2 Beta5 that contains quarkusio/gizmo#475.

[mkouba]

Both Maven Tests CI jobs failed with java.lang.OutOfMemoryError: Metaspace. @gsmet is it a known issue?

[Ladicek]

I have also seen OOM: Metaspace when testing the full Quarkus with rewritten ArC and it feels like it could be caused by Gizmo. I have no idea where to start looking though.

[gsmet]

Given you have DevUIQuteBuildTimeDataTest in the set of tests, it looks a bit suspicious.

We might have been just under the limit before though.

[mkouba]

Given you have DevUIQuteBuildTimeDataTest in the set of tests, it looks a bit suspicious.

We might have been just under the limit before though.

@gsmet @Ladicek Ah, I'll take a look!

[Ladicek]

We have -Xmx1500m -XX:MaxMetaspaceSize=1500m defined in build-parent/pom.xml. I tried setting both values to 5000m and still hit the OOM :-/

[mkouba]

Given you have DevUIQuteBuildTimeDataTest in the set of tests, it looks a bit suspicious.

We might have been just under the limit before though.

FTR it's a ClassLoader leak caused by the usage of ClassValue caches in the io.quarkus.gizmo2.impl.Util.

[gsmet]

@radcortez this test io.quarkus.cli.config.SetConfigTest.addEncryptedConfiguration has been failing a few times lately. I'm not sure if the problem is with the encrypted value or the way we decode it but it would be nice to fix it if possible.

[radcortez]

Strange... I'll have a look.

[Ladicek]

LGTM. I only checked the Gizmo 1 -> 2 conversion, not the code logic. I added many comments, most of them are just my opinion, but there's nothing wrong.

I also noticed (but forgot to comment) that on may places, you create an empty array of given size and immediately fill it with given values. There's a method newArray() that takes a list of arbitrary values and a mapping function to turn those values into Exprs, which would turn those places into one-liners.

[mkouba]

I also noticed (but forgot to comment) that on may places, you create an empty array of given size and immediately fill it with given values. There's a method newArray() that takes a list of arbitrary values and a mapping function to turn those values into Exprs, which would turn those places into one-liners.

Nice. I actually changed the code to use the variant that accepts a list of Expr but the result should be the same.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4b1f7bf.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/smallrye-reactive-messaging/deployment

❌ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

• Expecting actual: ["-6","-7","-9","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"] - java.lang.AssertionError

java.lang.AssertionError: 

Expecting actual:
  ["-6","-7","-9","-10","-11","-12","-13","-14"]
to start with:
  ["-6", "-7", "-8", "-9"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)

---

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/grpc-hibernate

❌ com.example.grpc.hibernate.VertxBlockingRawTest.shouldAdd - History

• Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)