Skip to content

Fix Allow setting MariaDB/MySQL storage engine differently for each persistence unit in Hibernate ORM #49902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix Allow setting MariaDB/MySQL storage engine differently for each persistence unit in Hibernate ORM #49902

wants to merge 1 commit into from

Conversation

@dreab8
Copy link
Contributor

@dreab8 dreab8 commented Sep 5, 2025 •
edited
Loading

@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive labels Sep 5, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 5, 2025

/cc @gsmet (hibernate-orm)

@dreab8 dreab8 requested a review from yrodiere September 5, 2025 13:46
yrodiere
yrodiere approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Though, obviously, we'll put this on ice until we upgrade to the relevant version of Hibernate ORM.

@yrodiere yrodiere added the triage/on-ice Frozen until external concerns are resolved label Sep 5, 2025
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/cache area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/hibernate-validator Hibernate Validator labels Sep 5, 2025
@dreab8 dreab8 force-pushed the GHQUARKUS-456 branch 2 times, most recently from faece61 to 6a09051 Compare September 5, 2025 20:05
@quarkus-bot quarkus-bot bot added area/agroal area/docstyle issues related for manual docstyle review area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/maven area/oidc area/rest area/rest-client area/security labels Sep 5, 2025
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

😭 Deploy PR Preview failed.

@yrodiere
Copy link
Member

yrodiere commented Sep 8, 2025

@dreab8 I think something went wrong with your rebase 🤔

@dreab8
Copy link
Contributor Author

dreab8 commented Sep 8, 2025

@yrodiere I hope now it's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yrodiere yrodiere yrodiere approved these changes

Assignees

No one assigned

Labels

area/agroal area/arc Issue related to ARC (dependency injection) area/cache area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/gradle Gradle area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/hibernate-validator Hibernate Validator area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/maven area/oidc area/rest area/rest-client area/security triage/on-ice Frozen until external concerns are resolved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow setting MariaDB/MySQL storage engine differently for each persistence unit in Hibernate ORM

2 participants

@dreab8 @yrodiere