-
Notifications
You must be signed in to change notification settings - Fork 3k
Allow to set default value for config options with AsciiDoc attributes #51098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow to set default value for config options with AsciiDoc attributes #51098
Conversation
gsmet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, thanks a lot. I added a couple of minor comments.
...-doc-maven-plugin/src/main/java/io/quarkus/maven/config/doc/generator/AbstractFormatter.java
Outdated
Show resolved
Hide resolved
core/runtime/src/main/java/io/quarkus/runtime/annotations/ConfigDocDefault.java
Outdated
Show resolved
Hide resolved
...java/io/quarkus/annotation/processor/documentation/config/scanner/ConfigMappingListener.java
Outdated
Show resolved
Hide resolved
...java/io/quarkus/annotation/processor/documentation/config/scanner/ConfigMappingListener.java
Outdated
Show resolved
Hide resolved
Thanks! Processed your feedback, if it looks good I can squash the commits |
bb41584 to
a565a95
Compare
This comment has been minimized.
This comment has been minimized.
|
🎊 PR Preview 6248693 has been successfully built and deployed to https://quarkus-pr-main-51098-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
gsmet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments.
extensions/narayana-lra/deployment/src/main/java/lra-devservice.properties
Outdated
Show resolved
Hide resolved
|
Also, not sure if you're aware but we can probably also improve things for these (not sure they are all used for Dev Services but at least some of them are): |
1934889 to
4915616
Compare
This comment has been minimized.
This comment has been minimized.
4915616 to
80dcb3f
Compare
624d20b to
133abdf
Compare
gsmet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool. I spotted one minor thing but other than that, I think it looks good to go.
...tasource/runtime/src/main/java/io/quarkus/datasource/runtime/DevServicesBuildTimeConfig.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
gsmet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome work, thanks a lot!
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✔️ | JVM Tests - JDK 17 | Logs | Raw logs | 🚧 | ||
| ✔️ | JVM Tests - JDK 21 | Logs | Raw logs | 🚧 | ||
| ✔️ | JVM Tests - JDK 25 | Logs | Raw logs | 🚧 | ||
| ❌ | JVM Tests - JDK 17 Windows | Build |
Failures | Logs | Raw logs | 🚧 |
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 17 Windows #
- Failing: extensions/grpc/deployment
! Skipped: devtools/bom-descriptor-json extensions/liquibase/liquibase-mongodb/deployment extensions/micrometer-opentelemetry/deployment and 12 more📦 extensions/grpc/deployment
❌ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.1:testCompile (default-testCompile) on project quarkus-grpc-deployment: Compilation failure
/D:/a/quarkus/quarkus/extensions/grpc/deployment/target/generated-test-sources/protobuf/grpc-java/io/grpc/examples/helloworld/v2/GreeterGrpc.java:[148,46] incompatible types: inference variable ResponseT has incompatible bounds
equality constraints: ReqT,RespT,io.grpc.examples.helloworld.v2.HelloReply
lower bounds: io.grpc.examples.helloworld.v2.HelloRequest
Flaky tests - Develocity
⚙️ MicroProfile TCKs Tests
📦 tcks/microprofile-lra
❌ org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable - History
Expecting the metric Compensated callback was called Expected: a value equal to or greater than <1> but: <0> was less than <1>-java.lang.AssertionError
java.lang.AssertionError:
Expecting the metric Compensated callback was called
Expected: a value equal to or greater than <1>
but: <0> was less than <1>
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.eclipse.microprofile.lra.tck.TckRecoveryTests.assertMetricCallbackCalled(TckRecoveryTests.java:210)
at org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable(TckRecoveryTests.java:195)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

Make it possible to use AsciiDoc attributes directly in the
ConfigDocDefaultannotation. This is especially useful to pass Maven properties as AsciiDoc attributes to the config properties as a default value for the documentation.For example, we now define the
keycloak.docker.imagein a central place, however we lost the default value in the documentation. With this change we can also use AsciiDoc attributes as default value again for the documentation.This should cover the initial idea from @gsmet, see #51024 (comment)
Locally this rendered the default value again for the Keycloak Docker image
DEV SERVICES OVERVIEW
@asciidoclet✅Kafka -> version centrally set in the extension itself for each providerKubernetes -> N/A - different flavours, so did not change anything hereVault -> N/A - Quarkiverse@asciidoclet✅Observability -> version centrally set in the extension itself