Prep changes for loading Maven POM 4.1#52715
Open
aloubyansky wants to merge 1 commit intoquarkusio:mainfrom
Open
Prep changes for loading Maven POM 4.1#52715aloubyansky wants to merge 1 commit intoquarkusio:mainfrom
aloubyansky wants to merge 1 commit intoquarkusio:mainfrom
Conversation
Status for workflow
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These code changes will be necessary to make the reproducer from #52190 work once we upgrade to the Maven dependency versions supporting model 4.1 API in #52491.
The reason we are not upgrading the dependency versions yet is because with the new dependency versions our CI times out. We'll need to make sure the new dependencies do not introduce memory-related issues.
I thought, given the code changes are relatively significant, it could be a good idea to merge them earlier to make sure they don't introduce regressions on their own.