Do not enforce UserInfo for OAuth2 if user prefers not to#52719
Open
sberyozkin wants to merge 1 commit intoquarkusio:mainfrom
Open
Do not enforce UserInfo for OAuth2 if user prefers not to#52719sberyozkin wants to merge 1 commit intoquarkusio:mainfrom
sberyozkin wants to merge 1 commit intoquarkusio:mainfrom
Conversation
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✔️ | JVM Tests - JDK 17 | Logs | Raw logs | 🔍 | ||
| ✔️ | JVM Tests - JDK 21 | Logs | Raw logs | 🔍 | ||
| ✔️ | JVM Tests - JDK 25 | Logs | Raw logs | 🔍 | ||
| ❌ | JVM Tests - JDK 25 Semeru | Build |
Logs | Raw logs | 🚧 |
You can consult the Develocity build scans.
michalvavrik
approved these changes
Feb 23, 2026
Member
michalvavrik
left a comment
There was a problem hiding this comment.
I thought about it a long while. I'd prefer if we were verifying a code flow to access token, but if user want to risk it fine. It would be nice if there was at least warning logged, or maybe there is warning logged on every request? Sorry, I had a long day so I didn't try it myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52651.
OAuth2 login should work only with the authorization and token endpoint URLs if it is what the users want - to have an authenticated access and use the access token to access this provider's API.
With this PR I was able to import GitHub MCP Server using the OAuth2 option.
These 2 properties in a test
do not have be set generally, it just happens the github provider set in the test enables
verify-access-token-with-user-infoand the code flow access token is activated becauseJsonWebTokenis injected in some resources