Skip to content

Reintroduce the automated sort of Comparable MultiBuildItems#53172

Merged
gsmet merged 2 commits intoquarkusio:mainfrom
gsmet:restore-builditem-comparable
Mar 24, 2026
Merged

Reintroduce the automated sort of Comparable MultiBuildItems#53172
gsmet merged 2 commits intoquarkusio:mainfrom
gsmet:restore-builditem-comparable

Conversation

@gsmet
Copy link
Member

@gsmet gsmet commented Mar 19, 2026

And use it to make ArC build reproducible.

Created as draft as I want a full CI run in my fork, and I still have to check a few things locally.

gsmet added 2 commits March 19, 2026 18:50
We dropped it at some point, but it was still documented, and actually
it makes a lot of sense now that we are making progress with build
reproducibility.
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/core labels Mar 19, 2026
@github-actions
Copy link

🎊 PR Preview 67be5bb has been successfully built and deployed to https://quarkus-pr-main-53172-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@gsmet gsmet marked this pull request as ready for review March 23, 2026 09:18
@gsmet gsmet requested review from Ladicek and mkouba March 23, 2026 09:18
@gsmet
Copy link
Member Author

gsmet commented Mar 23, 2026

@mkouba @Ladicek so this is another approach to #53088, implementing the Comparable behavior that was documented but not really used until now, and using it to fix the remaining issues I identified in ArC.

Got a fully green CI in my fork, which doesn't happen very often :]

Copy link
Member

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I can't say I understand the code around MultiBuildItems :-)

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 23, 2026

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 616ff11.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Logs Raw logs 🔍
✔️ JVM Tests - JDK 21 Logs Raw logs 🔍
✔️ JVM Tests - JDK 25 Logs Raw logs 🔍
JVM Tests - JDK 25 Semeru Build Failures Logs Raw logs 🔍
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 25 Semeru #

- Failing: extensions/grpc/runtime 
! Skipped: extensions/grpc/deployment extensions/grpc/inprocess extensions/grpc/runtime-dev and 27 more

📦 extensions/grpc/runtime

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.4:test (default-test) on project quarkus-grpc:

See /home/runner/work/quarkus/quarkus/extensions/grpc/runtime/target/surefire-reports for the individual test results.
See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
The forked VM terminated without properly saying goodbye. VM crash or System.exit called?


⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/panache/hibernate-orm-panache-kotlin/runtime extensions/panache/hibernate-reactive-panache-kotlin/runtime extensions/panache/mongodb-panache-kotlin/runtime and 2 more
! Skipped: extensions/panache/hibernate-orm-panache-kotlin/deployment extensions/panache/hibernate-reactive-panache-kotlin/deployment extensions/panache/mongodb-panache-kotlin/deployment and 2 more

📦 extensions/panache/hibernate-orm-panache-kotlin/runtime

Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:test-compile (test-compile) on project quarkus-hibernate-orm-panache-kotlin: Compilation failure Failed connecting to the daemon in 4 retries

📦 extensions/panache/hibernate-reactive-panache-kotlin/runtime

Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:kapt (kapt) on project quarkus-hibernate-reactive-panache-kotlin: Compilation failure Failed connecting to the daemon in 4 retries

📦 extensions/panache/mongodb-panache-kotlin/runtime

Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:compile (compile) on project quarkus-mongodb-panache-kotlin: Compilation failure Failed connecting to the daemon in 4 retries

📦 extensions/resteasy-reactive/rest-client-kotlin-serialization/tests

Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:test-compile (test-compile) on project quarkus-rest-client-kotlin-serialization-tests: Compilation failure Failed connecting to the daemon in 4 retries

📦 extensions/resteasy-reactive/rest-kotlin-serialization-common/deployment

Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:test-compile (test-compile) on project quarkus-rest-kotlin-serialization-common-deployment: Compilation failure Failed connecting to the daemon in 4 retries

@gsmet
Copy link
Member Author

gsmet commented Mar 24, 2026

@mkouba I would like to get your approval on this one given you pushed the idea. I want to make sure that's what you had in mind.

Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added one small comment but it looks good.

@gsmet gsmet merged commit 081a1cc into quarkusio:main Mar 24, 2026
82 of 84 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.35 - main milestone Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/arc Issue related to ARC (dependency injection) area/core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants