Skip to content

Conversation

@insectengine
Copy link
Collaborator

Contained in this commit:

  1. Added home page Commonhaus Foundation band (with dark and light mode support).
  2. Modified the footer band to accommodate CF requirements (logo/disclaimer text).
  3. Moved creative commons icons with links and the privacy policy links from the black bar to the subproject band.
  4. Refactored the media breaks and styling for the subproject band to make it a cleaner/visually compelling responsive design.

@github-actions
Copy link

github-actions bot commented Jul 16, 2025

🙈 The PR is closed and the preview is expired.

- page: Wallpapers
url: /desktopwallpapers
- page: Privacy Policy
url: https://www.redhat.com/en/about/privacy-policy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the Red Hat privacy policy still apply? Commonhaus has one for itself (but not necessarily for its projects): https://www.commonhaus.org/policies/privacy-policy/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The privacy policy is required since we're still using Adobe Analytics. This covers us for GDPR compliance.

@holly-cummins
Copy link
Contributor

holly-cummins commented Jul 17, 2025

On my screen (which is large, but not redonculously large), the sizing seems a bit off, relative to the text in the other bands:

image

The screen cap doesn't really capture it (since the screen cap is in a smaller space), but the logo is huge, and takes up almost the whole of the large window.

Also, I wonder if the text next to the logo would look better if it was vertically centred, so it was less out of alignment with the text in the logo?

If I shrink the window and change the aspect ratio, the alignment looks "right", and the size of the logo seems sensible:

image

So I wonder if we just need an upper cap on the size of the logo on wide screens, so it doesn't take up the whole vertical space?

@insectengine
Copy link
Collaborator Author

insectengine commented Jul 17, 2025

@holly-cummins - We use a 12 column grid and that version it was a 7/5 split of logo to content. I've reversed it to 5/7 with my last commit.

My screen cap at 1920...
Screenshot 2025-07-17 at 2 20 11 PM

@Sanne
Copy link
Member

Sanne commented Jul 18, 2025

It looks great and I'm eager to merge it - would it be ok if I pressed the big green button?

I do have some minor nitpicks but I think I'd prefer to let @insectengine to choose if he'd want to handle them as a follow up or not at all :)

Here is my screenshot (just the bottom bit):

image

Two things stand out:

  • the commonhaus logo in the footer seems rather big - perhaps it should be of similar height of the Quarkus logo which is in the center/top of the picture?
  • the "Sponsored by" lettering seems to drift a bit far from the Red Hat logo on such a display

Both of these look totally fine on mobile though. I appreciate my display is large 3360x1440 - on the other hand I expect most developers to have large screens, often even larger.

Neither seem blocking so I'd rather merge and polish later though. It's also still undecided if we should keep the "Sponsored by Red Hat" altogether so wouldn't want you to spend too many cycles on it, if it's not a trivial change.

@Sanne
Copy link
Member

Sanne commented Jul 18, 2025

It looks great and I'm eager to merge it - would it be ok if I pressed the big green button?

Actually let's just do it, @insectengine I'll leave it up to you to decide if my nitpicks are worthy of a follow up. Thanks a lot!

@Sanne Sanne merged commit 9a21a91 into quarkusio:main Jul 18, 2025
1 check passed
@cescoffier
Copy link
Member

Thanks @insectengine, @holly-cummins and @Sanne. The same should be used in the other CommonHaus project that moved at the same time as Quarkus (SmallRye, Qbic)

\CC @radcortez @dmlloyd @jponge

@jponge
Copy link
Member

jponge commented Jul 18, 2025

Thanks I'll transition that to the Mutiny projects, and future releases will reflect that change.

@Sanne
Copy link
Member

Sanne commented Jul 18, 2025

Good point, but bear in mind that there's the possibility that @insectengine will want to apply some more tweaks - perhaps give it some days for things to settle, so to avoid a multitude of patches.

@insectengine
Copy link
Collaborator Author

@Sanne - Think this issue will require a change of how this is built as columns based layout will force this space. We can limit the size of the CF logo, but that will just emphasize the spacing problem. I'll have to refactor this a bit #bigscreenproblems

@jponge @radcortez @dmlloyd - hold off on this until I get this sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants