Skip to content

Conversation

@insectengine
Copy link
Collaborator

This should clear up issues on ultra large screens but I have no way to test this locally.

@github-actions
Copy link

github-actions bot commented Jul 18, 2025

🙈 The PR is closed and the preview is expired.

@Sanne
Copy link
Member

Sanne commented Jul 18, 2025

I can confirm that the logo size is better scaled, and the "Sponsored by" is nicely followed by "Red Hat" logo, positioned not too far away.

But let me show you something else a bit odd;
footer:
image

top of page:
image

I hope you can see that: in the footer the sequence [commonhaus logo, trademarks links, redhat logo] seem all pushed to the left - to the point that the Red Hat logo is more on the left than the Quarkus logo which is in the center of the page.

Is that intentional? It's a little surprising, especially as the top menu seems to spread out well from left to right using all available width.

@insectengine
Copy link
Collaborator Author

Some screenshots of the footer at various points of repsonsiveness.

Screenshot 2025-07-18 at 2 40 24 PM Screenshot 2025-07-18 at 2 40 52 PM Screenshot 2025-07-18 at 2 40 33 PM

On the Project sub-footer (the part with desc, links and such). The quarkus horizontal logo is intended to be centered.
Screenshot 2025-07-18 at 3 44 10 PM

In general, for desktop is designed around looking the best at 1920px wide, the site is designed to have 13rem of padding on the left and right (it's considerably smaller on mobile and tablet). This means, if you're in mega theatrical wide wide mode of 3500px, it's going to look a bit... stretched out.

One option is to look to fix the width of the content at 1920. So at larger sizes you'll get a centered site with extra padding on the sides. We used to have the site fixed but I think folks wanted it to fill. Not sure what the answer is here.

@Sanne
Copy link
Member

Sanne commented Jul 19, 2025

@insectengine the screenshots you shared look fine - I would agree that even while many might have super-wide screens, we don't usually show the browser on full-screen so don't spend too much time on this.

One option is to look to fix the width of the content at 1920. So at larger sizes you'll get a centered site with extra padding on the sides. We used to have the site fixed but I think folks wanted it to fill.

Personally I think it would be fine to cap the width in case of it getting just too much, but I wonder what happens on high dpi screens? I don't have one of those - is that possibly why some folks wanted it to fill?
If that's not the case I'd suggest don't try to make everyone happy, you're the expert and can decide to make some tradeoffs; personally I think what you have above is beatiful in all setups we care about.

@holly-cummins
Copy link
Contributor

I haven't looked at the changes yet, but last week I was thinking "should I suggest to @insectengine that flexbox makes everything better? No, Holly, don't do that, James has lots of things to be doing without refactoring column layouts away just because they're not the current fashion ... "

So I'm happy to see this change arrived without me even having to irritate anyone :)

@Sanne
Copy link
Member

Sanne commented Jul 21, 2025

Should we merge this?

@holly-cummins
Copy link
Contributor

Should we merge this?

Just looking now!

@holly-cummins holly-cummins merged commit 5dc533b into quarkusio:main Jul 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants