Skip to content

Conversation

@fjuma
Copy link
Collaborator

@fjuma fjuma commented Sep 15, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 15, 2025

🙈 The PR is closed and the preview is expired.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAde some comment on the API, nothing blocking.

.preferredTransport(TransportProtocol.HTTP_JSON.asString()) <2>
.additionalInterfaces(List.of(
new AgentInterface(TransportProtocol.HTTP_JSON.asString(),
YOUR_HTTP_JSON_URL) <3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that what is used in the case of negotiation? If so, why do I have to repeat it? (The order could be used, no?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where we specify the transport and the URL combinations that are supported by the server and their order.

It's not strictly required to repeat the preferred transport here (since it will be added automatically by the AgentCard.Builder() if it's not specified by the user). I'll tweak the description here to mention that it's optional.

However, any other transports the server will support must be specified here. What repetition/order are you referring to?

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the publication date, the rest is great!

@cescoffier cescoffier merged commit d7ab4ce into quarkusio:main Sep 17, 2025
1 check passed
@cescoffier
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants