Skip to content

Conversation

@fjuma
Copy link
Collaborator

@fjuma fjuma commented Sep 23, 2025

** If you are updating a guide, please submit your pull request to the main repository: https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc **

@fjuma fjuma requested a review from cescoffier September 23, 2025 21:06
@github-actions
Copy link

github-actions bot commented Sep 23, 2025

😭 Deploy PR Preview failed.

[source,properties]
----
# Use the same port for gRPC and HTTP
quarkus.grpc.server.use-separate-server=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like an explanation for this?
Something like:

This setting allows serving both plain HTTP and gRPC requests from the same HTTP server. Underneath it uses a Vert.x based gRPC server. If you set this setting to true, gRPC requests will be served on port 9000 (and gRPC Java will be used instead).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added this.

@cescoffier
Copy link
Member

I would recommend publishing it tomorrow, I believe the blog will be full of "release" posts today.

Copy link
Contributor

@kabir kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great!

Made some comments but nothing serious

...
----
<1> We can use `Client.builder(publicAgentCard)` to create our A2A client. We need to pass in the `AgentCard`
for the A2A server agent this client will be communicating with.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of '...for the A2A server agent...' we could put '...retrieved from the A2A server agent...'

an A2A server agent that doesn't support gRPC, this is the transport that would get used.
<6> We can optionally specify general client configuration and preferences here.
<7> Once our `Client` has been created, we can send a message to the A2A server agent. The client will automatically
use streaming if it's supported by both the server and the client.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although you've mentioned it earlier, it might be worth emphasising like you do for 5, that if the server doesn't support streaming it will fall back to non-streaming?

two types of `UpdateEvents` that can be received.
<3> A `TaskStatusUpdateEvent` notifies the client of a change in a task's status. This is typically used in streaming interactions. If this is the final event in the stream for this interaction, `taskStatusUpdateEvent.isFinal()`
will return `true`.
<4> A `TaskArtifactUpdateEvent` notifies the client that an artifact has been generated or updated. This is typically used in streaming interactions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe point out that artifacts contain the 'agent responses'

@fjuma
Copy link
Collaborator Author

fjuma commented Sep 24, 2025

Thank you both for the feedback! I've addressed all the comments and updated the date to tomorrow.

@fjuma fjuma requested a review from cescoffier September 24, 2025 16:59
@fjuma
Copy link
Collaborator Author

fjuma commented Sep 25, 2025

Corrected the date to Sept. 25th.

@cescoffier
Copy link
Member

@fjuma is it ready to be merged?

(yesterday, we got 4 release blog post :-))

@fjuma
Copy link
Collaborator Author

fjuma commented Sep 25, 2025

@cescoffier Yes, it's ready to be merged. Thanks!

@cescoffier cescoffier merged commit 5ce8674 into quarkusio:main Sep 25, 2025
1 check passed
@cescoffier
Copy link
Member

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants