Revealjs - Cleaning how theme dependency is processed #10657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscheid
reviewed
Aug 30, 2024
This happens with `quarto-html` dependency, which can be emptied when it contains only the `quarto-variables-start` part. Detecting this helps reduce unneeded typescript processing, and inserting an empty file.
cderv
force-pushed
the
revealjs/remove-sourcemapurl
branch
from
14f3fff to
0e0d27f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to do several things, as part of refactoring.
sourceMappingUrlcleaning we do for some themes with bootstrap is not done with revealjs. This refactor our code to do this. This will fix revealjsquarto.csscontains wrong sourceMappingUrl #10423With our current
quarto-htmldependency, used with revealjs, it leads to adding as dependency an empty file. Basically,quarto-html-<hash>.csswas only containingsourceMappingUrlcomment line, and now is empty. This PR now check for emptyness of the processed CSS file and if so, it does not add the CSS file as a HTML dependency. This save some typescript processing too.I did not add any test because not sure what should be tested in this case. I tried adding one to check that if a
quarto-html-<hash>.cssexists, it is not empty, but I think this was a bad test.Hopefully this change makes sense. Happy to discuss it.
Also, this PR uses now regex for the revealjs test that check a resource with hash, because it is at least the third time this week we would need to modify this test.