listing - link activation for categories should work on any window.lo… #10712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there no way for us to do something with Playwright? (I think we don't need to in this case, but I'm trying to understand the claim you made) |
|
(Looks good to me!) |
Oh sure with playwright. I was thinking no way in our current smoke and smoke-all way. |
…cation It requires to strip any query search or hash part from the URL before comparing it to the link retrieved in listings' items.
[skip ci]
cderv
force-pushed
the
listing/categories-links
branch
from
97ffff5 to
93db833
Compare
- Add a new playwright test for blog categories click - Refactor by using same project than the other tests for blog.
|
Test with playwright added. |
|
Thank you very much |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10710
quarto.jsprocessing for activating link should be impacted by a query or hash part in thewindow.locationThis simple fix ensure quarto does the categories search by comparing a clean offset path.
This has been tested and verified against a simple website with blog post. And also in browser console for quarto-web.
Test can't really be added because this is in-browser processing.