Fix support in PPTX for floatreftarget #10932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`quarto.utils.match` returns false not nil
leading to warning and empty content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10931
To my knownledge
quarto.utils.match()returns an element or false, and not nil. So this fixes the problem seen in Figure cross-reference divs not working for PowerPoint #10931Also I do believe that lua,pptx - add FloatRefTarget renderer #10117 can be improved by also supporting the example for Figure cross-reference divs not working for PowerPoint #10931 which is CrossRef divs with one image. So I added a conditional on it (it is either inline or block) and then some tests for it
I also added a test for the currently unsupported behavior which would have catch the Figure cross-reference divs not working for PowerPoint #10931 report IMO.