Chore/deno update 2024 09 #10940
Merged
Chore/deno update 2024 09 #10940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscheid
commented
Oct 2, 2024
|
@cderv In case you're curious, the test failure we're seeing is because of this: Note how we're passing the import map from the github cache. The github cache uses the latest release, and now these import maps are no longer compatible with each other. |
cscheid
force-pushed
the
chore/deno-update-2024-09
branch
from
bf4390d to
7408297
Compare
|
I'm going to merge this with the failing test (because the test needs a release to work, and it's easier to fix in this way.) |
I am not just to follow this really - our tests run with dev version AFIU. But we can discuss this tomorrow |
|
Look at where the import map is coming from here: https://github.com/quarto-dev/quarto-cli/actions/runs/11149485730/job/30988488885#step:26:226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Deno to 1.46.3 along with our dependencies, stdlib, build scripts, etc.