[LaTeX] Correctly move table caption in last footer when present #10970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n present in longtable environment Pandoc's table are longtable environment with a `\endlastfoot` containing a line rule. Caption needs to be below this and so the last thing inside the table footer. If not present, we keep placing table as last element of the longtable.
cscheid
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10956
Pandoc's table are creating longtable environment containing a
\endlastfootwhich also have a\bottomruleWith our current process caption is made last element of the table, and footer comes after.
This PR changes it by catching any
\endlastfootand moving the caption as last element there if present.Otherwise (
\endlastfootnot present), it does as before.Tests has been fixed (it was not really testing much before) and made as a smoke-all test.
It also includes a cross referenced table, which seems to work ok. I believe even if we do some processing in LUA for the tbl location, the post processing will apply anyway and move in the place decided by it.