Skip to content

Don't use deno cache with Quarto run when using dev version #10972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Don't use deno cache with Quarto run when using dev version #10972

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf95341
Revert "disable test temporarily"
cderv Oct 4, 2024
de7ad24
Don't use `--cached-only` with quarto run in dev mode.
cderv Oct 4, 2024
5c38d77
run the test on windows too.
cderv Oct 4, 2024
5e4f37a
Revert "run the test on windows too."
cderv Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/core/run/deno.ts
View file
Open in desktop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using quartoConfig from ../quarto.ts

If this is not ok to import from this file in deno.ts, then we could directly read the env var

getenv("QUARTO_DEBUG", "false") === "true"

Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { architectureToolsPath, resourcePath } from "../resources.ts";
import { RunHandler, RunHandlerOptions } from "./types.ts";
import { removeIfExists } from "../path.ts";
import { copyTo } from "../copy.ts";
import { quartoConfig } from "../quarto.ts";

export const denoRunHandler: RunHandler = {
canHandle: (script: string) => {
Expand Down Expand Up @@ -42,7 +43,8 @@ export const denoRunHandler: RunHandler = {
"run",
"--import-map",
importMap,
"--cached-only",
// --cached-only can only be used in bundles as vendoring is not done anymore in dev mode
...(quartoConfig.isDebug() ? [] : ["--cached-only"]),
"--allow-all",
"--unstable-kv",
"--unstable-ffi",
Expand Down
3 changes: 1 addition & 2 deletions tests/docs/run/test-stdlib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
// Temporarily turn this off.
// import { readLines } from "stdlib/io";
import { readLines } from "stdlib/io";
2 changes: 0 additions & 2 deletions tests/smoke/run/stdlib-run-version.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,4 @@ unitTest("stdlib-run-version", async () => {
});
console.log({result})
assert(result.success);
}, {
ignore: Deno.build.os == "windows",
});
Loading