Skip to content

chore(brand): deduplicate font imports #11104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

chore(brand): deduplicate font imports #11104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/core/sass/brand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ const brandTypographyBundle = (
"/* typography variables from _brand.yml */",
'// quarto-scss-analysis-annotation { "action": "push", "origin": "_brand.yml typography" }',
];
const typographyImports: string[] = [];
const typographyImports: Set<string> = new Set();
const fonts = brand.data?.typography?.fonts ?? [];

const pathCorrection = relative(brand.projectDir, brand.brandDir);
Expand Down Expand Up @@ -268,10 +268,10 @@ const brandTypographyBundle = (
googleFamily = thisFamily;
} else if (googleFamily !== thisFamily) {
throw new Error(
`Inconsisent Google font families found: ${googleFamily} and ${thisFamily}`,
`Inconsistent Google font families found: ${googleFamily} and ${thisFamily}`,
);
}
typographyImports.push(googleFontImportString(resolvedFont));
typographyImports.add(googleFontImportString(resolvedFont));
}
if (googleFamily === "") {
return undefined;
Expand Down Expand Up @@ -437,7 +437,7 @@ const brandTypographyBundle = (
// dependency: "bootstrap",
quarto: {
defaults: typographyVariables.join("\n"),
uses: typographyImports.join("\n"),
uses: Array.from(typographyImports).join("\n"),
functions: "",
mixins: "",
rules: "",
Expand Down
Loading